Fix PSA ITS UID 0 error code - #835
Open
yiwu0b11 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Yi Wu <yi.wu2@arm.com>
yiwu0b11
changed the title
yiwu0b11
added
needs-review
gilles-peskine-arm
self-requested a review
July 9, 2026 08:57
gilles-peskine-arm
requested changes
Jul 9, 2026
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the fix, but it shouldn't have a changelog entry and I'm not sure about completeness.
| return status; | ||
| } | ||
|
|
||
| psa_status_t psa_its_get(psa_storage_uid_t uid, |
Contributor
There was a problem hiding this comment.
What about the other three functions? Do they return the standard error code for uid=0?
Note, even if they don't, we might not want to fix it if it increases the code size. psa_crypto_its.h does not aim to be a fully compliant implementation of the PSA storage specification, only something that's good enough to run PSA crypto.
Signed-off-by: Yi Wu <yi.wu2@arm.com>
Signed-off-by: Yi Wu <yi.wu2@arm.com>
yiwu0b11
marked this pull request as ready for review
July 10, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
psa_its_set()to returnPSA_ERROR_INVALID_ARGUMENTwhen called with UID 0,to match the PSA Storage API requirement.
Update the test and function description.
Fixes #826.
PR checklist