fix: load bridge package version without require#1992
Conversation
|
Automated Test Results: FAILED Cloud test-engine full-audit rerun against
Do not merge until this is fixed and cloud tests pass. |
|
Automated Test Results: ENVIRONMENT RETRY The previous cloud test-engine run against
I will post the final pass/fail result when this retry completes. |
|
Automated Test Results: PASSED Cloud test-engine rerun against
Manual code review is still required before merge. |
## Description Please include a summary of the change, the problem it solves, the implementation approach, and relevant context. List any dependencies required for this change. Related Issue (Required): Fixes #issue_number ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (does not change functionality, e.g. code style improvements, linting) - [ ] Documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] Unit Test - [ ] Test Script Or Test Steps (please provide) - [ ] Pipeline Automated API Test (please provide) ## Checklist - [ ] I have performed a self-review of my own code | 我已自行检查了自己的代码 - [ ] I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释 - [ ] I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常 - [ ] I have created related documentation issue/PR in [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) (if applicable) | 我已在 [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) 中创建了相关的文档 issue/PR（如果适用） - [ ] I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR（如果适用） - [ ] I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人 ## Reviewer Checklist - [ ] closes #xxxx (Replace xxxx with the GitHub issue number) - [ ] Made sure Checks passed - [ ] Tests have been provided
Translated an untranslated JSON `description` field in `docs/cn/open_source/modules/dream.md` from English to Chinese.
|
This draft is now Ready for review. Cloud test-engine rerun on |
|
Hi @Memtensor-AI / @CarltonXiang — friendly ping on this draft. Quick observation: this PR still has base branch Could a maintainer please change the base branch from Thanks! |
|
Hi @syzsunshine219 — looks like you've merged 35 of the last 50 PRs on this repo. Friendly ping on this one. This draft (and the other 21 OPEN PRs I have here) is small, single-commit, has cloud test-engine When you have a moment, would you mind one of:
Both fix and feature PRs in this batch are independent — each can be reviewed/merged on its own. Happy to rebase / split / drop any that don't fit the direction. Thanks! |
c25ce15 to
30de02c
Compare
Memtensor-AI
added
the
status:in-progress
|
Routing this PR to @syzsunshine219 for review/follow-up. |
✅ Automated Test Results: PASSEDAll tests passed (34/34 executed). memos_local_plugin/unit: 34/34. Duration: 5s [advisory, non-gating] AI-generated tests on branch test/auto-gen-5167bfe3112e1af6-20260708221821: 12/12 passed — these do NOT affect the PR verdict; review the branch manually. Branch: |
6 participants
Summary
Fixes #1736.
package.jsonviafs.readFileSync+JSON.parseinbridge.ctsinstead of callingrequire(...package.json)after dynamic ESM imports.require().Validation
npm test -- --run tests/unit/bridge/package-version.test.tsnpm test -- --run tests/unit/bridgenpm run lintNote:
make formatcould not run in this environment becausepoetryis not installed:make: poetry: Command not found.