Skip to content

refactor: migrate buy button toast#44510

Open
n3ps wants to merge 1 commit into
mainfrom
n3ps/ceux-1188-50fc
Open

refactor: migrate buy button toast#44510
n3ps wants to merge 1 commit into
mainfrom
n3ps/ceux-1188-50fc

Conversation

@n3ps

@n3ps n3ps commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Migrates the toast notification when clicking the homescreen Buy button

Changelog

CHANGELOG entry: null

Related issues

Fixes: CEUX-1188

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only notification refactor with unchanged trigger conditions (non-ramps buy path); no auth, data, or payment logic changes.

Overview
Replaces the wallet overview Buy “tab opened” notification with the shared toast.success stack instead of a local multichain Toast + component state.

When ramps are disabled and Buy opens Portfolio in a new tab, the same copy and export icon are shown via ToastContent, with a stable toast id (buy-tab-opened-toast). The inline TabOpenedToast helper and showTabOpenedToast state/render path are removed.

Reviewed by Cursor Bugbot for commit e3b5cf0. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Jul 16, 2026
@metamask-ci

metamask-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f748e32]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 21c3992 | Date: 7/16/2026 | Pipeline: 29464091580 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -21%
  • loadNewAccount/total: -21%
  • loadNewAccount/fcp: -22%
  • confirmTx/longTaskTotalDuration: -20%
  • confirmTx/longTaskMaxDuration: -18%
  • confirmTx/tbt: -38%
  • confirmTx/inp: -30%
  • confirmTx/fcp: -22%
  • confirmTx/lcp: -13%
  • bridgeUserActions/bridge_load_page: -12%
  • bridgeUserActions/bridge_load_asset_picker: -17%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -36%
  • bridgeUserActions/longTaskMaxDuration: -28%
  • bridgeUserActions/tbt: -67%
  • bridgeUserActions/inp: -39%
  • bridgeUserActions/fcp: -22%
  • loadNewAccount/load_new_account: +599%
  • loadNewAccount/total: +599%
  • loadNewAccount/inp: +32%
  • loadNewAccount/fcp: -50%
  • loadNewAccount/lcp: +1178%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -10%
  • confirmTx/fcp: -47%
  • confirmTx/lcp: +1136%
  • bridgeUserActions/bridge_load_page: +94%
  • bridgeUserActions/bridge_load_asset_picker: +88%
  • bridgeUserActions/bridge_search_token: +199%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +174%
  • bridgeUserActions/inp: -21%
  • bridgeUserActions/lcp: +1183%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/domInteractive: -31%
  • startupStandardHome/initialActions: +11%
  • startupStandardHome/fcp: -33%
  • startupPowerUserHome/setupStore: +24%
  • startupPowerUserHome/inp: +17%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 232ms
  • 🟡 startupPowerUserHome/LCP: p75 3.4s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: -14%
  • onboardingImportWallet/doneButtonToHomeScreen: -91%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -60%
  • onboardingImportWallet/longTaskCount: -91%
  • onboardingImportWallet/longTaskTotalDuration: -97%
  • onboardingImportWallet/longTaskMaxDuration: -93%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -89%
  • onboardingNewWallet/srpButtonToPwForm: +15%
  • onboardingNewWallet/createPwToRecoveryScreen: +23%
  • onboardingNewWallet/skipBackupToMetricsScreen: +13%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +17%
  • onboardingNewWallet/doneButtonToAssetList: -14%
  • onboardingNewWallet/longTaskCount: -62%
  • onboardingNewWallet/longTaskTotalDuration: -82%
  • onboardingNewWallet/longTaskMaxDuration: -63%
  • onboardingNewWallet/tbt: -100%
  • onboardingNewWallet/total: -11%
  • solanaAssetDetails/assetClickToPriceChart: -65%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -65%
  • solanaAssetDetails/inp: -19%
  • solanaAssetDetails/cls: -86%
  • importSrpHome/loginToHomeScreen: -33%
  • importSrpHome/openAccountMenuAfterLogin: +24%
  • importSrpHome/homeAfterImportWithNewWallet: -74%
  • importSrpHome/longTaskCount: -55%
  • importSrpHome/longTaskTotalDuration: -66%
  • importSrpHome/longTaskMaxDuration: -34%
  • importSrpHome/tbt: -74%
  • importSrpHome/total: -70%
  • importSrpHome/inp: -41%
  • importSrpHome/fcp: -17%
  • importSrpHome/lcp: -67%
  • importSrpHome/cls: -47%
  • sendTransactions/openSendPageFromHome: -24%
  • sendTransactions/selectTokenToSendFormLoaded: +16%
  • sendTransactions/reviewTransactionToConfirmationPage: -72%
  • sendTransactions/longTaskCount: +67%
  • sendTransactions/longTaskTotalDuration: +49%
  • sendTransactions/longTaskMaxDuration: +49%
  • sendTransactions/tbt: -26%
  • sendTransactions/total: -70%
  • sendTransactions/cls: -86%
  • swap/openSwapPageFromHome: -36%
  • swap/fetchAndDisplaySwapQuotes: +105%
  • swap/longTaskCount: -100%
  • swap/longTaskTotalDuration: -100%
  • swap/longTaskMaxDuration: -100%
  • swap/tbt: -100%
  • swap/total: +106%
  • swap/inp: +11%
  • swap/cls: -86%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 109 Bytes (0%)
  • ui: -365 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: -28 Bytes (0%)

@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from f748e32 to 45d350a Compare July 17, 2026 19:11
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 19:11 Inactive
@github-actions github-actions Bot added size-L and removed size-M labels Jul 17, 2026
@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from 45d350a to 543ec53 Compare July 17, 2026 19:14
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 19:15 Inactive
@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from 543ec53 to f748e32 Compare July 17, 2026 19:21
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 19:21 Inactive
@github-actions github-actions Bot added size-M and removed size-L labels Jul 17, 2026
@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from f748e32 to e12f2d6 Compare July 17, 2026 19:43
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 19:43 Inactive
@github-actions github-actions Bot added size-S and removed size-M labels Jul 17, 2026
@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from e12f2d6 to 6657069 Compare July 17, 2026 19:48
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 19:48 Inactive
@github-actions github-actions Bot added size-M and removed size-S labels Jul 17, 2026
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 20:15 Inactive
@metamask-ci

metamask-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
Builds ready [6657069]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 10 warn · 🔴 2 fail)

Baseline (latest main): 7bfc16c | Date: 7/17/2026 | Pipeline: 29608899589 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 metricsToWalletReadyScreen(p95) [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 doneButtonToAssetList(p95) [CI log]🟡 [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +52%
  • loadNewAccount/total: +52%
  • loadNewAccount/inp: +11%
  • loadNewAccount/lcp: -18%
  • confirmTx/inp: +35%
  • bridgeUserActions/bridge_load_asset_picker: -13%
  • bridgeUserActions/longTaskCount: +25%
  • bridgeUserActions/longTaskTotalDuration: +13%
  • bridgeUserActions/inp: +30%
  • loadNewAccount/load_new_account: +107%
  • loadNewAccount/total: +107%
  • loadNewAccount/inp: -21%
  • loadNewAccount/fcp: -53%
  • loadNewAccount/lcp: +1019%
  • confirmTx/confirm_tx: +12%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +12%
  • confirmTx/fcp: -45%
  • confirmTx/lcp: +1141%
  • bridgeUserActions/bridge_load_page: +79%
  • bridgeUserActions/bridge_load_asset_picker: +110%
  • bridgeUserActions/bridge_search_token: +203%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +195%
  • bridgeUserActions/inp: +1770%
  • bridgeUserActions/lcp: +1162%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 bridgeUserActions/INP: p75 1.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -23%
  • startupStandardHome/load: -23%
  • startupStandardHome/domContentLoaded: -24%
  • startupStandardHome/domInteractive: -19%
  • startupStandardHome/firstPaint: -10%
  • startupStandardHome/backgroundConnect: -24%
  • startupStandardHome/firstReactRender: -22%
  • startupStandardHome/initialActions: -29%
  • startupStandardHome/loadScripts: -24%
  • startupStandardHome/setupStore: -31%
  • startupStandardHome/longTaskCount: -29%
  • startupStandardHome/longTaskTotalDuration: -30%
  • startupStandardHome/longTaskMaxDuration: -28%
  • startupStandardHome/tbt: -31%
  • startupStandardHome/inp: -10%
  • startupStandardHome/fcp: -23%
  • startupStandardHome/lcp: +230%
  • startupStandardHome/uiStartup: +14%
  • startupStandardHome/load: +15%
  • startupStandardHome/domContentLoaded: +16%
  • startupStandardHome/backgroundConnect: +13%
  • startupStandardHome/initialActions: +11%
  • startupStandardHome/loadScripts: +16%
  • startupStandardHome/setupStore: +166%
  • startupStandardHome/lcp: +15%
  • startupPowerUserHome/uiStartup: +14%
  • startupPowerUserHome/domInteractive: +26%
  • startupPowerUserHome/backgroundConnect: +13%
  • startupPowerUserHome/loadScripts: +11%
  • startupPowerUserHome/setupStore: +89%
  • startupPowerUserHome/fcp: +19%
  • startupPowerUserHome/lcp: +12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.4s
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -77%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -71%
  • onboardingImportWallet/longTaskCount: -91%
  • onboardingImportWallet/longTaskTotalDuration: -97%
  • onboardingImportWallet/longTaskMaxDuration: -93%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -75%
  • onboardingNewWallet/doneButtonToAssetList: +109%
  • onboardingNewWallet/longTaskCount: -74%
  • onboardingNewWallet/longTaskTotalDuration: -82%
  • onboardingNewWallet/longTaskMaxDuration: -63%
  • onboardingNewWallet/tbt: -98%
  • onboardingNewWallet/total: +101%
  • solanaAssetDetails/assetClickToPriceChart: -68%
  • solanaAssetDetails/total: -68%
  • solanaAssetDetails/inp: +15%
  • solanaAssetDetails/lcp: +12%
  • solanaAssetDetails/cls: -86%
  • importSrpHome/loginToHomeScreen: -44%
  • importSrpHome/openAccountMenuAfterLogin: -47%
  • importSrpHome/homeAfterImportWithNewWallet: -30%
  • importSrpHome/longTaskCount: -60%
  • importSrpHome/longTaskTotalDuration: -67%
  • importSrpHome/longTaskMaxDuration: -38%
  • importSrpHome/tbt: -70%
  • importSrpHome/total: -32%
  • importSrpHome/inp: -45%
  • importSrpHome/fcp: -19%
  • importSrpHome/lcp: -13%
  • importSrpHome/cls: -17%
  • sendTransactions/openSendPageFromHome: -48%
  • sendTransactions/selectTokenToSendFormLoaded: -39%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -97%
  • sendTransactions/inp: -39%
  • sendTransactions/cls: -53%
  • swap/openSwapPageFromHome: -21%
  • swap/fetchAndDisplaySwapQuotes: +111%
  • swap/longTaskCount: -100%
  • swap/longTaskTotalDuration: -100%
  • swap/longTaskMaxDuration: -100%
  • swap/tbt: -100%
  • swap/total: +109%
  • swap/inp: +15%
  • swap/lcp: -12%
  • swap/cls: -86%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 208ms
  • 🟡 assetDetails/FCP: p75 2.0s
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: +10%
Bundle size diffs
  • background: 105 Bytes (0%)
  • ui: 196 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 177 Bytes (0%)

@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from 6657069 to cc969c6 Compare July 17, 2026 22:59
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 22:59 Inactive
@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from cc969c6 to 43963f1 Compare July 17, 2026 23:04
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 23:04 Inactive
@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from 43963f1 to c927266 Compare July 17, 2026 23:07
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 23:07 Inactive
@cursor
cursor Bot temporarily deployed to pr-comment July 17, 2026 23:33 Inactive
@metamask-ci

metamask-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c927266]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): e8baf89 | Date: 7/17/2026 | Pipeline: 29619817200 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -22%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/total: -22%
  • loadNewAccount/inp: -29%
  • loadNewAccount/fcp: -28%
  • loadNewAccount/lcp: -32%
  • confirmTx/longTaskTotalDuration: -33%
  • confirmTx/longTaskMaxDuration: -37%
  • confirmTx/tbt: -61%
  • confirmTx/inp: -20%
  • confirmTx/fcp: -33%
  • confirmTx/lcp: -28%
  • bridgeUserActions/bridge_load_page: -52%
  • bridgeUserActions/bridge_load_asset_picker: -39%
  • bridgeUserActions/bridge_search_token: -12%
  • bridgeUserActions/longTaskCount: -38%
  • bridgeUserActions/longTaskTotalDuration: -52%
  • bridgeUserActions/longTaskMaxDuration: -33%
  • bridgeUserActions/tbt: -88%
  • bridgeUserActions/total: -17%
  • bridgeUserActions/inp: -27%
  • bridgeUserActions/fcp: -32%
  • bridgeUserActions/lcp: +519%
  • bridgeUserActions/cls: -100%
  • loadNewAccount/load_new_account: +68%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/total: +68%
  • loadNewAccount/inp: -21%
  • loadNewAccount/fcp: -49%
  • loadNewAccount/lcp: +1055%
  • confirmTx/confirm_tx: +12%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +12%
  • confirmTx/inp: -11%
  • confirmTx/fcp: -45%
  • confirmTx/lcp: +1179%
  • bridgeUserActions/bridge_load_page: +96%
  • bridgeUserActions/bridge_load_asset_picker: +85%
  • bridgeUserActions/bridge_search_token: +207%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +175%
  • bridgeUserActions/fcp: -44%
  • bridgeUserActions/lcp: +1236%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/domInteractive: +86%
  • startupStandardHome/initialActions: +25%
  • startupStandardHome/fcp: +83%
  • startupPowerUserHome/setupStore: +80%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.2s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/pwFormToMetricsScreen: -12%
  • onboardingImportWallet/doneButtonToHomeScreen: -84%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -23%
  • onboardingImportWallet/longTaskCount: -100%
  • onboardingImportWallet/longTaskTotalDuration: -100%
  • onboardingImportWallet/longTaskMaxDuration: -100%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -83%
  • onboardingNewWallet/doneButtonToAssetList: +44%
  • onboardingNewWallet/longTaskCount: -100%
  • onboardingNewWallet/longTaskTotalDuration: -100%
  • onboardingNewWallet/longTaskMaxDuration: -100%
  • onboardingNewWallet/tbt: -100%
  • onboardingNewWallet/total: +41%
  • solanaAssetDetails/assetClickToPriceChart: -67%
  • solanaAssetDetails/total: -67%
  • solanaAssetDetails/inp: +25%
  • solanaAssetDetails/lcp: +12%
  • solanaAssetDetails/cls: -86%
  • importSrpHome/loginToHomeScreen: -23%
  • importSrpHome/openAccountMenuAfterLogin: -44%
  • importSrpHome/homeAfterImportWithNewWallet: -27%
  • importSrpHome/longTaskCount: -44%
  • importSrpHome/longTaskTotalDuration: -47%
  • importSrpHome/tbt: -47%
  • importSrpHome/total: -26%
  • importSrpHome/inp: -15%
  • importSrpHome/cls: -17%
  • sendTransactions/openSendPageFromHome: -39%
  • sendTransactions/selectTokenToSendFormLoaded: +23%
  • sendTransactions/reviewTransactionToConfirmationPage: -97%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -30%
  • sendTransactions/lcp: -11%
  • sendTransactions/cls: -86%
  • swap/fetchAndDisplaySwapQuotes: +106%
  • swap/longTaskCount: -100%
  • swap/longTaskTotalDuration: -100%
  • swap/longTaskMaxDuration: -100%
  • swap/tbt: -100%
  • swap/total: +104%
  • swap/cls: -86%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 264ms
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 2.0s
  • 🟡 swap/FCP: p75 2.0s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 105 Bytes (0%)
  • ui: 348 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 231 Bytes (0%)

@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from c927266 to aa3b6ee Compare July 18, 2026 04:35
@cursor
cursor Bot temporarily deployed to pr-comment July 18, 2026 04:35 Inactive
@github-actions github-actions Bot added size-S and removed size-M labels Jul 18, 2026
@n3ps n3ps changed the title refactor: migrate coin buttons toast (CEUX-1188) refactor: migrate buy button toast Jul 18, 2026
@n3ps
n3ps marked this pull request as ready for review July 18, 2026 04:39
@n3ps
n3ps enabled auto-merge July 18, 2026 04:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit aa3b6ee. Configure here.

<Icon name={IconName.Export} color={IconColor.IconDefault} />
),
},
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale locale in buy toast

Low Severity

Buy-tab toast strings are resolved via t() inside handleBuyAndSellOnClick, but that callback’s dependency list omits t. After the user changes locale, a Buy click can show the previous language because the memoized handler still closes over the old t, unlike the removed toast component that read t on render.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit aa3b6ee. Configure here.

Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
@cursor
cursor Bot force-pushed the n3ps/ceux-1188-50fc branch from aa3b6ee to e3b5cf0 Compare July 18, 2026 04:44
@cursor
cursor Bot temporarily deployed to pr-comment July 18, 2026 04:44 Inactive
@sonarqubecloud

Copy link
Copy Markdown

@cursor
cursor Bot temporarily deployed to pr-comment July 18, 2026 05:07 Inactive
@metamask-ci

metamask-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor
Builds ready [e3b5cf0]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 13 warn · 🔴 0 fail)

Baseline (latest main): e8baf89 | Date: 7/17/2026 | Pipeline: 29631054874 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +55%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/total: +55%
  • loadNewAccount/inp: +11%
  • loadNewAccount/lcp: -12%
  • confirmTx/tbt: +13%
  • confirmTx/inp: +25%
  • confirmTx/fcp: +24%
  • confirmTx/lcp: +99%
  • bridgeUserActions/bridge_load_page: -20%
  • bridgeUserActions/longTaskCount: +25%
  • bridgeUserActions/longTaskTotalDuration: +17%
  • bridgeUserActions/inp: +36%
  • loadNewAccount/load_new_account: +622%
  • loadNewAccount/longTaskCount: -100%
  • loadNewAccount/longTaskTotalDuration: -100%
  • loadNewAccount/longTaskMaxDuration: -100%
  • loadNewAccount/tbt: -100%
  • loadNewAccount/total: +622%
  • loadNewAccount/inp: -13%
  • loadNewAccount/lcp: +1182%
  • confirmTx/confirm_tx: +12%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +12%
  • confirmTx/inp: -11%
  • confirmTx/fcp: +19%
  • confirmTx/lcp: +1216%
  • bridgeUserActions/bridge_load_page: +180%
  • bridgeUserActions/bridge_load_asset_picker: +107%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +178%
  • bridgeUserActions/fcp: -41%
  • bridgeUserActions/lcp: +1271%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/domInteractive: +38%
  • startupStandardHome/initialActions: -38%
  • startupStandardHome/setupStore: -10%
  • startupStandardHome/fcp: +42%
  • startupPowerUserHome/uiStartup: -15%
  • startupPowerUserHome/load: -11%
  • startupPowerUserHome/domContentLoaded: -11%
  • startupPowerUserHome/backgroundConnect: -21%
  • startupPowerUserHome/firstReactRender: -16%
  • startupPowerUserHome/loadScripts: -12%
  • startupPowerUserHome/setupStore: -89%
  • startupPowerUserHome/inp: -18%
  • startupPowerUserHome/fcp: -11%
  • startupPowerUserHome/lcp: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.6s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • onboardingImportWallet/doneButtonToHomeScreen: -93%
  • onboardingImportWallet/longTaskCount: -91%
  • onboardingImportWallet/longTaskTotalDuration: -96%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -81%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • onboardingNewWallet/doneButtonToAssetList: +49%
  • onboardingNewWallet/longTaskCount: -74%
  • onboardingNewWallet/longTaskTotalDuration: -79%
  • onboardingNewWallet/longTaskMaxDuration: -55%
  • onboardingNewWallet/tbt: -91%
  • onboardingNewWallet/total: +47%
  • solanaAssetDetails/assetClickToPriceChart: -71%
  • solanaAssetDetails/total: -71%
  • solanaAssetDetails/inp: +25%
  • solanaAssetDetails/cls: -86%
  • importSrpHome/loginToHomeScreen: -38%
  • importSrpHome/openAccountMenuAfterLogin: -66%
  • importSrpHome/homeAfterImportWithNewWallet: -37%
  • importSrpHome/longTaskCount: -58%
  • importSrpHome/longTaskTotalDuration: -63%
  • importSrpHome/longTaskMaxDuration: -21%
  • importSrpHome/tbt: -67%
  • importSrpHome/total: -37%
  • importSrpHome/inp: -38%
  • importSrpHome/fcp: -11%
  • importSrpHome/cls: -17%
  • sendTransactions/openSendPageFromHome: -52%
  • sendTransactions/selectTokenToSendFormLoaded: -33%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -96%
  • sendTransactions/inp: -33%
  • sendTransactions/lcp: -12%
  • sendTransactions/cls: -86%
  • swap/openSwapPageFromHome: -30%
  • swap/fetchAndDisplaySwapQuotes: +101%
  • swap/longTaskCount: -17%
  • swap/longTaskMaxDuration: -24%
  • swap/tbt: -100%
  • swap/total: +99%
  • swap/inp: +16%
  • swap/cls: -86%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 105 Bytes (0%)
  • ui: -386 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: -60 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants