refactor: migrate buy button toast#44510
Conversation
Builds ready [f748e32]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
f748e32 to
45d350a
Compare
45d350a to
543ec53
Compare
543ec53 to
f748e32
Compare
f748e32 to
e12f2d6
Compare
e12f2d6 to
6657069
Compare
Builds ready [6657069]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 10 warn · 🔴 2 fail)
Bundle size diffs
|
6657069 to
cc969c6
Compare
cc969c6 to
43963f1
Compare
43963f1 to
c927266
Compare
Builds ready [c927266]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
c927266 to
aa3b6ee
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aa3b6ee. Configure here.
| <Icon name={IconName.Export} color={IconColor.IconDefault} /> | ||
| ), | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Stale locale in buy toast
Low Severity
Buy-tab toast strings are resolved via t() inside handleBuyAndSellOnClick, but that callback’s dependency list omits t. After the user changes locale, a Buy click can show the previous language because the memoized handler still closes over the old t, unlike the removed toast component that read t on render.
Reviewed by Cursor Bugbot for commit aa3b6ee. Configure here.
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
aa3b6ee to
e3b5cf0
Compare
|
Builds ready [e3b5cf0]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 13 warn · 🔴 0 fail)
Bundle size diffs
|





Description
Migrates the toast notification when clicking the homescreen Buy button
Changelog
CHANGELOG entry: null
Related issues
Fixes: CEUX-1188
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only notification refactor with unchanged trigger conditions (non-ramps buy path); no auth, data, or payment logic changes.
Overview
Replaces the wallet overview Buy “tab opened” notification with the shared
toast.successstack instead of a local multichainToast+ component state.When ramps are disabled and Buy opens Portfolio in a new tab, the same copy and export icon are shown via
ToastContent, with a stable toast id (buy-tab-opened-toast). The inlineTabOpenedToasthelper andshowTabOpenedToaststate/render path are removed.Reviewed by Cursor Bugbot for commit e3b5cf0. Bugbot is set up for automated code reviews on this repo. Configure here.