fix: dedicated convert mUSD details cp-13.41.0#44586
Open
n3ps wants to merge 7 commits into
Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (6 files, +137 -56)
|
n3ps
commented
Jul 17, 2026
| * | ||
| * @param hash - The activity item hash | ||
| */ | ||
| export function useTransactionMeta(hash: string | undefined) { |
Contributor
Author
There was a problem hiding this comment.
extracted from other locally-enriched detail pages
n3ps
commented
Jul 17, 2026
| return <BridgeDetails item={item} />; | ||
| case 'swap': | ||
| case 'convert': | ||
| return <ConvertDetails item={item} />; |
n3ps
commented
Jul 17, 2026
| toEvmCaipChainId(ARBITRUM_USDC.chainId), | ||
| ); | ||
|
|
||
| function useTransactionMeta(hash: string | undefined) { |
Contributor
Author
There was a problem hiding this comment.
extracted into useLocalTransactionMeta
n3ps
commented
Jul 17, 2026
| >; | ||
| }; | ||
|
|
||
| function useTransactionMeta(hash: string | undefined) { |
Contributor
Author
There was a problem hiding this comment.
extracted into useLocalTransactionMeta
# Conflicts: # ui/hooks/activity/useCachedEvmTransaction.ts # ui/pages/details/hooks/useCachedEvmTransaction.ts # ui/pages/details/templates/perps-deposit-details.tsx # ui/pages/details/templates/swap-details.tsx # ui/pages/details/templates/template-loader.tsx # ui/pages/details/transaction-details.tsx # ui/pages/details/useCachedEvmTransaction.ts
n3ps
force-pushed
the
n3ps/dedicated-convert-musd-details
branch
from
July 17, 2026 02:35
daa09e3 to
99b9aa4
Compare
n3ps
marked this pull request as ready for review
July 17, 2026 02:52
n3ps
enabled auto-merge
July 17, 2026 02:52
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
n3ps
commented
Jul 17, 2026
| item: Extract< | ||
| ActivityListItem, | ||
| { | ||
| type: |
Contributor
Author
There was a problem hiding this comment.
convert is currently shared in this union type
Contributor
Builds ready [d1ac92e]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 7 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [17d0dd6]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 7 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
force-pushed
the
n3ps/dedicated-convert-musd-details
branch
from
July 17, 2026 15:51
17d0dd6 to
ba39d23
Compare
Contributor
Builds ready [ba39d23]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [a82b3d1]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
commented
Jul 17, 2026
| ? nonEvmActivityItems.get(txIdentifier.toLowerCase()) | ||
| : undefined; | ||
|
|
||
| const cachedApiTransaction = useCachedEvmTransaction({ |
Contributor
Author
There was a problem hiding this comment.
extracted into useApiTransaction
Contributor
Builds ready [df03a38] [reused from a82b3d1]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [df03a38] [reused from a82b3d1]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [df03a38] [reused from a82b3d1]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
added
the
retry-ci
n3ps
changed the title
Contributor
Builds ready [df03a38] [reused from a82b3d1]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Contributor
Builds ready [7e9c5b2] [reused from a82b3d1]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splits the locally-enriched mUSD conversion from the swap-details template into a dedicated template.
Fixes the empty source token row and adds the transaction steps summary
Changelog
CHANGELOG entry: Fixed the mUSD conversion activity details
Related issues
Fixes: https://consensys.slack.com/archives/C09AYKX30P3/p1784182784586309
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only activity detail routing and display; no auth or transaction submission changes. Convert details render nothing when local transaction meta is missing.
Overview
convertactivity items now use a dedicatedConvertDetailstemplate instead of sharingSwapDetails, so mUSD-style conversions can show localmetamaskPaydata (USD network fee, total, and step summary) and a Convert again footer without swap-specific fee rows or block explorer.You sent is filled by loading the source chain transaction (
metamaskPay.sourceHash/chainId) via a newuseApiTransactionhook (cache + API query) and deriving the sent amount from value transfers.Shared hooks
useLocalTransactionMetaanduseApiTransactionreplace duplicated local-meta lookup in perps templates and inline fetch logic intransaction-details.Reviewed by Cursor Bugbot for commit 7e9c5b2. Bugbot is set up for automated code reviews on this repo. Configure here.