Fix reading list items displaying order starting from 0#545
Merged
Conversation
- The `order` field on `ReadingListItem` defaulted to 0, causing items created via the Django admin inline (without an explicit order value) to display as "0" in the reading list detail view. - Add a data migration to renumber any affected lists starting from 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orderfield onReadingListItemhaddefault=0, causing items added via the Django admin inline (without an explicit value) to display as "0" in the reading list detail view instead of a 1-based position.1.0009) to renumber any existing reading lists whose first item hasorder=0, preserving relative ordering.