Skip to content

fix: issue when YSU_MODE=all explicitly set - #157

Open
MichaelAquilina wants to merge 1 commit into
masterfrom
fix/154
Open

fix: issue when YSU_MODE=all explicitly set#157
MichaelAquilina wants to merge 1 commit into
masterfrom
fix/154

Conversation

@MichaelAquilina

Copy link
Copy Markdown
Owner

Fixes #154

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts alias suggestion behavior in YSU_MODE=ALL to avoid recommending less-specific aliases when the user is already using a more-specific alias, addressing the incorrect hinting described in #154.

Changes:

  • Add logic in _check_aliases (ALL mode) to detect the “best coverage” alias already used by the typed command and suppress less-specific suggestions.
  • Add zunit tests covering the new ALL-mode specificity behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
you-should-use.plugin.zsh Refines ALL-mode alias recommendation logic to avoid less-specific alias suggestions when a more-specific alias is already in use.
tests/test_aliases.zunit Adds regression tests for ALL-mode specificity filtering behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread you-should-use.plugin.zsh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reminder fires even when I use the correct alias

2 participants