fix: issue when YSU_MODE=all explicitly set - #157
Open
MichaelAquilina wants to merge 1 commit into
Open
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR adjusts alias suggestion behavior in YSU_MODE=ALL to avoid recommending less-specific aliases when the user is already using a more-specific alias, addressing the incorrect hinting described in #154.
Changes:
- Add logic in
_check_aliases(ALL mode) to detect the “best coverage” alias already used by the typed command and suppress less-specific suggestions. - Add zunit tests covering the new ALL-mode specificity behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| you-should-use.plugin.zsh | Refines ALL-mode alias recommendation logic to avoid less-specific alias suggestions when a more-specific alias is already in use. |
| tests/test_aliases.zunit | Adds regression tests for ALL-mode specificity filtering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MichaelAquilina
force-pushed
the
fix/154
branch
from
February 26, 2026 11:49
082a34b to
b473669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154