Clarify Raw Input buffer semantics, alignment, and handle lifetime#2190
Open
DJm00n wants to merge 6 commits into
Open
Clarify Raw Input buffer semantics, alignment, and handle lifetime#2190DJm00n wants to merge 6 commits into
DJm00n wants to merge 6 commits into
Conversation
Updated alignment requirements and error handling details for the GetRawInputBuffer function. Clarified the behavior of the function when reading raw input messages from the queue.
|
@DJm00n : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Added code example for aligning RAWINPUT structure on WOW64.
Corrected a note regarding RAWINPUT alignment for WOW64.
DJm00n
changed the title
GrantMeStrength
approved these changes
Jul 17, 2026
GrantMeStrength
left a comment
GrantMeStrength
left a comment
Contributor
There was a problem hiding this comment.
LGTM — accurate technical correction. Approved.
Contributor
|
@copilot /review |
GrantMeStrength
approved these changes
Jul 17, 2026
GrantMeStrength
left a comment
GrantMeStrength
left a comment
Contributor
There was a problem hiding this comment.
Reviewed ✅ — Documentation improvement looks good.
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies previously undocumented behavior of
GetRawInputBufferandGetRawInputData.Changes
GetMessageremovesWM_INPUTfrom the raw input queue before returning, making it invisible toGetRawInputBufferGetRawInputData(lParam)first, thenGetRawInputBufferin a loopHRAWINPUThandle lifetime: freed on nextGetMessage/PeekMessage(PM_REMOVE)pcbSizesemantics, legacy HTML linksSee also MicrosoftDocs/win32#2168