Update routing_controller.dart - #1792
Open
mhbdev wants to merge 1 commit into
Open
Conversation
Solves Milad-Akarie#1789 This commit will affect AutoTabsRouter path stacking. If the user click on the back button and activeIndex is not homeIndex, then pops to previous active tab not homeIndex.
Author
|
I think I have to consider another condition! Considering that the user has passed through these routes: homeIndex is 0. DashBoard -> homeIndex -> 2 -> 1 -> homeIndex -> 3 -> 4 On pop goes from 4 to 3 and then homeIndex and finally pop the whole app. I have to check if there is no previous route at all, then pop the whole app if the user is on homeIndex. |
Owner
|
Hey @mhbdev I haven't tested the code yet but from a first a glance I think it might cause a non-ending loop since setActiveRoute sets the previous index. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1789
This commit will affect AutoTabsRouter path stacking. If the user click on the back button and activeIndex is not homeIndex, then pops to previous active tab not homeIndex.