fix: re-enable args equality by default - #2175
Open
daniellampl wants to merge 1 commit into
Open
Conversation
daniellampl
force-pushed
the
enable-args-equality-by-default
branch
from
March 26, 2025 16:20
72441e3 to
59a4785
Compare
|
This is a must have, or at least the readme update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After migrating to auto_route > 10, I noticed that some of our tests failed due to args equality being disabled. While this is somewhat mentioned in the
CHANGELOG, it is not explicitly marked as a "BREAKING CHANGE", which it clearly is. Alternatively, providing a migration guide would clarify it, but ideally, args equality should be an opt-out feature rather than opt-in.