✨ Add SLSGetWindowLevel inside window validation checks#1088
Merged
Conversation
SLSGetWindowLevelSLSGetWindowLevel inside window validation checks
SenpaiHunters
approved these changes
Apr 29, 2026
Owner
Author
|
Thanks for the update @AlejandroVolkova! I can’t reproduce it anymore either, but it’s likely that it was instead PR #1087 fixed it. It introduced a new SkyLight check called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the window level check only existed in
Window.fromWindowInfo, since that was the only public way to retrieve a window's level. With SkyLight, we can now fetch a window'sCGWindowLeveldirectly viaSLSGetWindowLevel, allowing the check to live inWindow's main initializer and apply to every code path. This lets Loop automatically reject intentionally floating windows (such as the notch window from Alcove and likely other notch apps) instead of relying on per-app blacklisting to keep Loop from manipulating them.Note that the original
Window.fromWindowInfocheck has been kept as an early bail-out, as it lets Loop reject invalid windows up front using data already in hand, avoiding an unnecessarySkyLightcall :)