✨ Reverse-engineer SLSWindowTags + handle sharp inset corners on preview#1090
Merged
✨ Reverse-engineer SLSWindowTags + handle sharp inset corners on preview#1090
SLSWindowTags + handle sharp inset corners on preview#1090Conversation
MrKai77
force-pushed
the
kai/reverse-engineer-slswindowtags
branch
from
2ece09c to
ea25753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Hopper to reverse-engineer the full
SLSWindowTagsbit layout. Names every bit position 0-63 against SkyLight's internal short-debug-name table, which is the binary's own bit-position-ordered name list and is authoritative for current macOS. This includes several bits Apple has inserted since NUIKit's reverse-engineered headers were last updated (WindowManagerAware,FriendOfFullscreen,IgnoreForScreenSharing, etc.).Closes #1083, using our suggested fix, and includes @AlejandroVolkova's comment about windows with smaller titlebars:
