Support private repositories in remote sources - #10
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MrPunyapal
marked this pull request as ready for review
August 22, 2026 12:34
Add environment-based credential resolution when fetching remote Git sources: - New Docsmith\RemoteSources\SourceCredentials resolves a per-source token: explicit 'token' => '\' references (missing variables throw InvalidSourcesConfiguration naming the variable and target), literal tokens, or automatic fallbacks — DOCSMITH_TOKEN for any HTTPS host, GITHUB_TOKEN/GH_TOKEN only ever for github.com. Fallbacks are never attached to plain-HTTP repositories. - DocumentationSource accepts optional 'token' and 'username' manifest keys (default username: x-access-token). - SourceSynchronizer attaches resolved credentials via RemoteRepository::withCredentials() and appends a private-repository hint to RepositoryNotFoundException failures raised without credentials. - Bump mrpunyapal/git-reader to ^0.2; tests run against the currently pinned release through a conditional compatibility shim.
MrPunyapal
force-pushed
the
feat/private-source-auth
branch
from
August 22, 2026 16:18
87577b7 to
946a428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remote sources can now authenticate to private Git repositories.
Why
docsmith.sources.php currently only supports public repositories, which blocks syncing internal packages. Authentication belongs at the transport layer, so git-reader 0.2 gained HTTP basic auth and this change wires manifest configuration into it without docsmith knowing any transport details.
Notes for review
pint, phpstan, and pest pass (81 tests, 296 assertions).