Added disabled flag to commands - #185
Open
Dustinhoefer wants to merge 1 commit into
Open
Conversation
|
You could add the field dynamically during parsing if it's missing, defaulting to false. Or if the field isn't present in the config, just treat the command as enabled. |
Member
|
Hi @Dustinhoefer , Thanks for the PR! Sorry for the late response. I think I'm going to implement this a bit differently, but I'll keep the PR open for now in case that doesn't end up happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to completely disable some commands.
Since this was not possible, I added a flag "disabled" (default false) for commands.
Questions:
Is there a way we could make it so that we do NOT have to change the config.json, because
this PR would be a breaking change for others (they need to add "disabled" to all commands ...)