refactor(recipes): add typed tokenizer construction#3009
Draft
akoumpa wants to merge 1 commit into
Draft
Conversation
3 tasks
Contributor
Author
|
/ok to test 90f69ef |
3 tasks
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
59212e4 to
e8a8666
Compare
90f69ef to
fe566cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TokenizerConfig.build()for tokenizer and multimodal processor factoriesnull, top-level factories, model fallback, and trust policy at theRecipeConfigboundary_build_tokenizerhelper and its cross-recipe importWhy
This is the second follow-up layer on #2390 and depends on #3008. It keeps declarative tokenizer construction out of recipe bodies and preserves config state across builds.
Validation
uv run ruff format .uv run ruff check --fix .uv run lint-importsuv run python -m compileall -q nemo_automodelStack
Checklist