fix(test): use SDPA for Nemotron-H HF reload#3060
Merged
Merged
Conversation
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
Contributor
Author
|
/ok to test 2ff349d |
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
8 tasks
Contributor
Author
|
/ok to test 96423b4 |
Contributor
Author
|
@akoumpa can you bless this PR? |
akoumpa
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sdpawhen checkpoint robustness loads a Nemotron-H model through Hugging Face remote codeflash_attention_2for other remote-code models, including Nemotron-FlashWhy
AM-672 fails while the vanilla-HF reference model runs through Hugging Face's FlashAttention varlen/unpadding path. Nemotron-H triggers a CUDA
vectorized_gather_kernelindex-out-of-bounds assert there. The later tensor-representation error and NCCL failures are secondary symptoms of rank 0's asynchronous CUDA failure.PyTorch SDPA avoids the incompatible HF varlen path while retaining optimized CUDA attention dispatch. The explicit reload synchronization also prevents other ranks from hitting the default 600-second process-group timeout while rank 0 is still loading the 120B HF reference.
Validation
python -m pytest tests/unit_tests/ci_tests/test_checkpoint_robustness_hf_kwargs.py -q— 6 passed, including the real two-process synchronization regressionruff format --checkon both changed filesruff checkon both changed filesnemotron_super_v3_hellaswag_peft(job 362958206)The separate vLLM deploy result in that combined pipeline belongs to #3061 / AM-668 and does not affect this HF checkpoint-robustness fix.
Linear: AM-672