chore: bump python default to 3.13#463
Open
binaryaaron wants to merge 3 commits into
Open
Conversation
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mckornfield
previously approved these changes
May 4, 2026
| # Switch to "devel" if a future dependency requires CUDA compilation. | ||
| ARG CUDA_IMAGE_TYPE=runtime | ||
| ARG PYTHON_VERSION=3.11.13 | ||
| ARG PYTHON_VERSION=3.13 |
Collaborator
There was a problem hiding this comment.
did we want a minor or nah?
| info = field[1] | ||
| anno = getattr(info, "annotation", None) | ||
| anno_type = type(anno) | ||
| if getattr(anno_type, "__origin__", None) is typing.Union: |
Collaborator
There was a problem hiding this comment.
is this diff for 3.13 or just cleanup?
| ### Prerequisites | ||
|
|
||
| - Python 3.11–3.13 (we pin a specific 3.11.x in `.python-version` for local/dev bootstrap; any 3.11, 3.12, or 3.13 interpreter works. Python 3.14+ is NOT supported because ray, a transitive dependency of vLLM, does not yet publish `cp314` wheels) | ||
| - Python 3.11–3.13 (`.python-version` pins 3.13 for local/dev bootstrap; any 3.11, 3.12, or 3.13 interpreter works. Python 3.14+ is NOT supported because ray, a transitive dependency of vLLM, does not yet publish `cp314` wheels) |
Collaborator
There was a problem hiding this comment.
freakin ray. we don't even do distributed stuff yeah?
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing_extensionsbackports foroverride/TypeIsand document that shared syntax stays Python 3.11-compatible until NMP moves to 3.12.Test plan