fix(onboard): clarify messaging skip prompt

[WuKongAI-CMU]

Summary

• Clarify the messaging channel selector prompt so users know selecting no channels skips the step
• Add a regression test that keeps the skip wording in the onboarding prompt

Fixes #3471.

Verification

• git diff --check
• npm test -- test/onboard.test.ts -t "selecting no messaging channels skips"

Signed-off-by: Intern Dev dev@wukongai.io

Summary by CodeRabbit

• Tests

  • Added test to validate the onboarding messaging channel selection prompt accurately conveys the skip behavior.

• Documentation

  • Updated the messaging channel selection prompt during onboarding to reflect that no selection skips this setup step.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: db217106-8917-472f-922d-e1d9fa752102

📥 Commits

Reviewing files that changed from the base of the PR and between 1bdb519 and 4044e3e.

📒 Files selected for processing (2)

• src/lib/onboard.ts
• test/onboard.test.ts

---

📝 Walkthrough

Walkthrough

The messaging channel selection prompt is updated to clarify that pressing Enter with no channels selected skips the setup step. A test validates that this skip behavior is documented in the prompt text.

Changes

Messaging Channel Selection Skip Behavior

Layer / File(s)	Summary
Clarify skip behavior in messaging channel prompt src/lib/onboard.ts, test/onboard.test.ts	Messaging channel prompt appends "(none selected skips)" to clarify that pressing Enter without selecting any channels skips setup. A test verifies this wording appears in the prompt.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A prompt that whispers "skip with care,
Press Enter, leave the fields bare,"
🐰 No channels? That's just fine,
The path to freedom, crystal-line!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: clarifying the messaging skip prompt in the onboarding flow.
Linked Issues check	✅ Passed	The PR successfully addresses issue #3471 by clarifying the onboarding prompt to indicate that selecting no channels skips the step, and adds a regression test to ensure this behavior is maintained.
Out of Scope Changes check	✅ Passed	All changes are directly related to the linked issue: prompt text clarification in src/lib/onboard.ts and a corresponding test in test/onboard.test.ts.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch codex/plugin-test-script

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wscurran]

✨ Thanks for submitting this PR to clarify the messaging channel selector prompt and add a regression test to ensure the skip wording is correct. This change aims to improve the onboarding process by making it clearer that selecting no channels skips the step.

---

Related open issues:

• #3471 UX issue: Why no skipping option for Messaging?

[cjagwani]

/ok to test 4044e3e

[cjagwani]

Hey @WuKongAI-CMU — change looks good and the fix matches the issue's UX ask, but the commit shows as Unverified on GitHub. NemoClaw requires verified commits before merge.

[jyaunches]

@WuKongAI-CMU thanks for the fix here. This PR is blocked by commit signature requirements, so I opened #4027 with the same/squashed work from a signed commit and will close this one to unblock the change.

For your next PR, please configure GitHub-verified commit signing before opening it so the required signature check passes on the original PR. GitHub docs: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[jyaunches]

Closing in favor of #4027 because this PR is blocked by commit signature requirements.

[jyaunches]

Correction: I acted on the wrong PR number here. I am reopening #3480 and leaving this PR as-is; the signature-rescue workflow was intended for #3840.

[cjagwani]

Heads-up @WuKongAI-CMU — opened #4026 carrying this forward from a maintainer branch. This PR is double-blocked by:

1. Commit verification (no_user, see the earlier comment).
2. The same stale-fork build-sandbox-images failure hitting fix(policy): match custom presets when computing gateway-active set #3641 (plugin already exists) — unrelated to your diff, but blocks merge.

Rather than wait on both, #4026 applies the same prompt-text update against current main (text retargeted from the now-refactored MESSAGING_CHANNELS.length to availableChannels.length), and is 28/28 green on CI.

Plan is to close this as superseded once #4026 merges — flag if you'd prefer otherwise. Thanks for surfacing the UX issue.