Skip to content

docs(rfc): add sandbox resource requirements proposal#1360

Merged
TaylorMutch merged 2 commits into
NVIDIA:mainfrom
elezar:1338-sandbox-resource-requirements/elezar
May 22, 2026
Merged

docs(rfc): add sandbox resource requirements proposal#1360
TaylorMutch merged 2 commits into
NVIDIA:mainfrom
elezar:1338-sandbox-resource-requirements/elezar

Conversation

@elezar
Copy link
Copy Markdown
Member

@elezar elezar commented May 13, 2026

Summary

Add RFC 0004 proposing a typed sandbox resource requirements model for CPU, memory, GPUs, and future resource domains. The RFC separates portable resource requirements from driver/platform-specific configuration and realization, and includes concrete realization examples for Kubernetes, Docker, Podman, and VM drivers.

Related Issue

Related to #1338 and #1340.

Changes

  • Adds rfc/0004-sandbox-resource-requirements/README.md.
  • Proposes SandboxSpec.resource_requirements with compute, device, dataset, and extension domains.
  • Reserves JSON-formatted CLI input for --driver-config-json, mapped to SandboxTemplate.driver_config.
  • Explicitly avoids exposing JSON-formatted portable resource request flags.
  • Documents how CPU/memory and GPU requests map to Kubernetes resources, CDI device injection, and VM device assignment.
  • Captures conflict handling between portable resource requirements and SandboxTemplate.resources passthrough.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated (not applicable; RFC-only change)
  • E2E tests added/updated (not applicable; RFC-only change)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@elezar elezar requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 13, 2026 14:54
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the 1338-sandbox-resource-requirements/elezar branch from 96945aa to 1aafb69 Compare May 13, 2026 16:29
@drew drew mentioned this pull request May 14, 2026
5 tasks
Comment thread rfc/0004-sandbox-resource-requirements/README.md Outdated
@drew drew added the rfc label May 14, 2026
Comment thread rfc/0004-sandbox-resource-requirements/README.md
Comment thread rfc/0004-sandbox-resource-requirements/README.md
Copy link
Copy Markdown
Collaborator

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good next step. I wanted to let @mrunalp take a look as well, but this is LGTM for me.

@drew drew moved this from Todo to In progress in OpenShell Roadmap May 15, 2026
drew
drew previously approved these changes May 15, 2026
Copy link
Copy Markdown
Collaborator

@drew drew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread rfc/0004-sandbox-resource-requirements/README.md Outdated
Comment thread rfc/0004-sandbox-resource-requirements/README.md Outdated
@elezar
Copy link
Copy Markdown
Member Author

elezar commented May 22, 2026

Filed a follow-up investigation issue for the sandbox manifest / openshell apply -f proposal raised in this discussion: #1520.

That should let this RFC stay focused on typed resource requirements while tracking the declarative sandbox spec work separately.

@TaylorMutch TaylorMutch merged commit 18988bd into NVIDIA:main May 22, 2026
26 of 27 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in OpenShell Roadmap May 22, 2026
@elezar elezar deleted the 1338-sandbox-resource-requirements/elezar branch May 22, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants