Skip to content

ci(canary): keep helm jwt secret generation enabled#1521

Merged
TaylorMutch merged 1 commit into
mainfrom
fix-release-canary-jwt-secret/tm
May 22, 2026
Merged

ci(canary): keep helm jwt secret generation enabled#1521
TaylorMutch merged 1 commit into
mainfrom
fix-release-canary-jwt-secret/tm

Conversation

@TaylorMutch
Copy link
Copy Markdown
Collaborator

Summary

Fix the Release Canary Kubernetes Helm job by keeping the chart's PKI/JWT init hook enabled. TLS remains disabled for the canary, but the gateway pod still mounts the sandbox JWT signing secret generated by that hook.

Related Issue

N/A

Related failed run: https://github.com/NVIDIA/OpenShell/actions/runs/26263108448

Changes

  • Remove the --set pkiInitJob.enabled=false override from the Release Canary Helm install.
  • Update the test-release-canary skill's local kind reproduction notes to keep the hook enabled when TLS is disabled.

Testing

  • git diff --check
  • mise run pre-commit passes
    • Skipped at maintainer request for this workflow-only fix.
  • Unit tests added/updated
  • E2E tests added/updated
    • Not applicable; this updates the release canary workflow itself.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch TaylorMutch enabled auto-merge (squash) May 22, 2026 13:20
@TaylorMutch TaylorMutch merged commit 48333e5 into main May 22, 2026
26 checks passed
@TaylorMutch TaylorMutch deleted the fix-release-canary-jwt-secret/tm branch May 22, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants