ci(canary): keep helm jwt secret generation enabled#1521
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
pimlock
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Release Canary Kubernetes Helm job by keeping the chart's PKI/JWT init hook enabled. TLS remains disabled for the canary, but the gateway pod still mounts the sandbox JWT signing secret generated by that hook.
Related Issue
N/A
Related failed run: https://github.com/NVIDIA/OpenShell/actions/runs/26263108448
Changes
--set pkiInitJob.enabled=falseoverride from the Release Canary Helm install.test-release-canaryskill's local kind reproduction notes to keep the hook enabled when TLS is disabled.Testing
git diff --checkmise run pre-commitpassesChecklist