ci(release): skip python rpm in gateway smoke test#1559
Merged
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-1559.docs.buildwithfern.com/openshell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Fedora RPM smoke test to install only the CLI and gateway RPMs before running
openshell-gateway --version. The previous*.rpmglob also installed the optional Python SDK RPM, which is not needed for this gateway smoke check.Fedora fixed the earlier Rocky-specific Python ABI issue, but the smoke still failed because
python3-openshell-0.0.48-1.fc44requirespython3.14dist(grpcio) >= 1.60andpython3.14dist(protobuf) >= 4.25, which Fedora 44 does not provide. Since this smoke validates the gateway package path, skipping the Python subpackage avoids blocking the release on unrelated SDK RPM dependencies.Related Issue
None. Follow-up from failed release run https://github.com/NVIDIA/OpenShell/actions/runs/26415139181/job/77759471779.
Changes
./package-input/*.rpmwith explicit CLI and gateway RPM globs in the release-tag RPM smoke step.python3-openshellout of the gateway smoke install path.Testing
mise run pre-commitpasses.ruby -e "require 'yaml'; YAML.load_file('.github/workflows/release-tag.yml'); puts 'ok'".26415139181artifacts:docker run --rm --platform linux/amd64 -v ... fedora:latest bash -lc 'set -euo pipefail; dnf install -y /work/package-input/openshell-[0-9]*.rpm /work/package-input/openshell-gateway-*.rpm; openshell-gateway --version'returnedopenshell-gateway 0.0.48.Checklist