feat: Changes to svpc/dpa to allow Spectrum X partitioning and allow …#1791
Merged
Conversation
…flexible tenant configuration Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
…flexible tenant configuration Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
…flexible tenant configuration Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
kensimon
requested changes
May 26, 2026
Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-05-26 22:35:31 UTC | Commit: dd6387f |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
…flexible tenant configuration Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
kensimon
approved these changes
May 28, 2026
Coco-Ben
requested changes
May 28, 2026
| @@ -1,17 +1,17 @@ | |||
| # NVIDIA Infra Controller (NICo) Core Metrics | |||
Contributor
There was a problem hiding this comment.
Changes in this file are a regression (switches back to old terms that are no longer valid) and should be removed from the PR.
Contributor
There was a problem hiding this comment.
This file is autogenerated when you run tests. So name should be fixed here:
Contributor
Author
There was a problem hiding this comment.
I did not change that file. That line (line 221 in crates/api-integration-tests/tests/lib.rs) is the same in my branch as what is in the main branch.
Contributor
Author
There was a problem hiding this comment.
Reverted my changes to core_metrics.md
Contributor
There was a problem hiding this comment.
Here is the fix for metrics names generation: #2017
poroh
reviewed
May 28, 2026
…flexible tenant configuration Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
Coco-Ben
approved these changes
May 29, 2026
lachen-nv
approved these changes
May 29, 2026
…flexible tenant configuration Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
aadvani-nvidia
approved these changes
May 30, 2026
| pub mod route_server; | ||
| pub mod site_explorer; | ||
| pub mod sku; | ||
| pub mod spx_partition; |
Contributor
There was a problem hiding this comment.
Do we need this - seems to be the only change in the file.
| mod db_init; | ||
| mod dhcp; | ||
| mod dpa; | ||
| mod dpa_monitor; |
chet
approved these changes
May 30, 2026
…flexible tenant configuration Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
chet
approved these changes
May 30, 2026
Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
rtamma-nv
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…flexible tenant configuration
Description
Enable SPX partitions, and tenant configuration allows flexible
assignment of SPX partitions to instance interfaces.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes
Tested these changes in my dev env setup using mock dpa. These changes are for the SVPC offering. Astra changes will follow.