chore(model): reduce dependency of model from secrets#1856
Merged
Conversation
poroh
force-pushed
the
model-secrets-dep-reduction
branch
from
11a01d5 to
6725562
Compare
secrets crate brings some heavy-weight dependencies like vault-rs and other. We can start compiling model earlier if this dependency is reduced. Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
poroh
force-pushed
the
model-secrets-dep-reduction
branch
from
6725562 to
28bb3c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
secrets crate brings some heavy-weight dependencies like vault-rs and other. We can start compiling model earlier if this dependency is reduced.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes