Fix UE 5.8 compile errors from FJsonObject key-type change - #46
Open
mflannigan042 wants to merge 1 commit into
Open
Fix UE 5.8 compile errors from FJsonObject key-type change#46mflannigan042 wants to merge 1 commit into
mflannigan042 wants to merge 1 commit into
Conversation
UE 5.8 changed FJsonObject::Values map key type from FString to UE::FSharedString, breaking every call site that passed Pair.Key directly to APIs expecting an FString. Converts affected keys with FString(Key.ToView()) and fixes an FSharedString::ToUpper() call that no longer exists (route through FString first). Also bumps UnrealClaude.uplugin EngineVersion to 5.8.0. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
thanks, I tested and built successful :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FJsonObject::Values's map key type fromFStringtoUE::FSharedString, which broke every call site that passedPair.Keydirectly into APIs expecting anFString(TSet<FString>::Contains,TArray<FString>::Add,TMap<FString,...>::Add, and a few tool-specific setter functions).FString(Key.ToView())before use.FSharedString::ToUpper()call (no longer exists on that type) withFString(Key.ToView()).ToUpper().UnrealClaude.upluginEngineVersionto5.8.0(and updates the description string) since the plugin now targets 5.8.Verification
Built clean end-to-end via:
against a UE 5.8.0 engine install. All 73 compile units succeeded, plugin DLL linked without errors.
Test plan
BuildPluginvia RunUAT against UE 5.8 completes withBUILD SUCCESSFUL