Fix OperandReferenceAnalyzer to recognize all undefined data types - #9401
Merged
Conversation
Contributor
Author
|
Minimized reproduction: gcc 1.c -o a.out Expected Result (Slot 1 is a pointer): Actual Result (Slot 1 is undefined): Here is the compiled binary: (a.out.zip). |
Contributor
Author
|
Disclosure: I added tests with help of an AI assistant. I also manually verified that UndefinedArray test is, in fact, a regression test. |
Contributor
|
Looks good. Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Undefined.isUndefined(dt)instead ofdt instanceof Undefined, so that multi-byte undefined types are detected as undefined.The
instanceofcheck missed some variants of undefined causing the analyzer to treat them as defined and skip creating pointer references on them.