Use flint_vsnprintf in FLINT error handling - #2317
Open
lgoettgens wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2317 +/- ##
==========================================
- Coverage 88.28% 88.25% -0.03%
==========================================
Files 102 102
Lines 37842 37833 -9
==========================================
- Hits 33408 33389 -19
- Misses 4434 4444 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of letting FLINT print to stdout and capturing that.
Unfortunately, we have to guess a maximum length to allocate the formatted message string. The classic approach of calling
vsnprintftwice, once with a NULL buffer to obtain the length as the return value and then a second time with an allocated buffer to the exact size, does not work here, as it requires us to copy the va_list. And I don't really see a way to do that from julia.