Skip to content

NFC: ISO 15693-3 emulation READ_MULTI and GET_BLOCK_SECURITY fixes#501

Merged
WillyJL merged 8 commits intodevfrom
fix/patch-iso15693-crash
Jan 25, 2026
Merged

NFC: ISO 15693-3 emulation READ_MULTI and GET_BLOCK_SECURITY fixes#501
WillyJL merged 8 commits intodevfrom
fix/patch-iso15693-crash

Conversation

@aaronjamt
Copy link
Copy Markdown
Member

@aaronjamt aaronjamt commented Jan 1, 2026

What's new

Fixes some errors in ISO 15693-3 emulation, namely READ MULTI command returning 1 block more than expected, and crashing with some unexpectedly large command responses (issue #417).

  • Fixes the bug in issue NFC emulate ISO15693-3 Flipper crash and reboot #417 (hopefully)
  • Fixes READ MULTI returning 1 more block than expected (ISO 15693-3 READ MULTI has the block count in the command as 1 less than what should be returned, eg command with block count 0 should return 1 block, this was previously returning 2 blocks instead)
  • Allocates enough response buffer size for a full 256 block response to BLOCK SECURITY command
  • Fixes READ MULTI so that asking for more blocks than can fit into the response buffer will return an error instead of crashing

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@WillyJL WillyJL force-pushed the fix/patch-iso15693-crash branch from 5284682 to 7f55f4c Compare January 1, 2026 02:16
@aaronjamt aaronjamt marked this pull request as ready for review January 1, 2026 02:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

Compiled f7 firmware for commit 3ec9be65:

@WillyJL WillyJL changed the title Fix #417 NFC: ISO 15693-3 READ MULTI and BLOCK SECURITY fixes Jan 1, 2026
@WillyJL
Copy link
Copy Markdown
Member

WillyJL commented Jan 1, 2026

this makes sense to me, but im drafting until i can check on a real card in a few days what it does with a READ MULTI command larger than it can handle, if it just errors or if it returns less blocks than asked.

@WillyJL WillyJL marked this pull request as draft January 1, 2026 23:18
@aaronjamt
Copy link
Copy Markdown
Member Author

Given the positive response in #417, I'd say this is probably ready for undraft and merge.

@WillyJL WillyJL added the bugfix Something isn't working label Jan 25, 2026
@WillyJL WillyJL moved this to In Progress in Momentum Progress Tracker Jan 25, 2026
@WillyJL WillyJL marked this pull request as ready for review January 25, 2026 22:24
@WillyJL
Copy link
Copy Markdown
Member

WillyJL commented Jan 25, 2026

this makes sense to me, but im drafting until i can check on a real card in a few days what it does with a READ MULTI command larger than it can handle, if it just errors or if it returns less blocks than asked.

checked with SLIX2, there is no reply if asked for too many blocks in one "read multi" command. changed behavior to mirror that

@WillyJL WillyJL changed the title NFC: ISO 15693-3 READ MULTI and BLOCK SECURITY fixes NFC: ISO 15693-3 emulation READ_MULTI and GET_BLOCK_SECURITY fixes Jan 25, 2026
@WillyJL WillyJL merged commit c176524 into dev Jan 25, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Momentum Progress Tracker Jan 25, 2026
@WillyJL WillyJL deleted the fix/patch-iso15693-crash branch January 25, 2026 22:47
@aaronjamt aaronjamt linked an issue Jan 25, 2026 that may be closed by this pull request
segnini75 pushed a commit to segnini75/Momentum-Firmware that referenced this pull request Feb 6, 2026
Merging latest dev branch changes into kiisu-mntm.

Major changes merged from dev:
- NFC: ISO 15693-3 emulation READ_MULTI and GET_BLOCK_SECURITY fixes (Next-Flip#501)
- NFC: Fix sending 32+ byte ISO 15693-3 commands
- Archive: Support opening and pinning ProtoPirate files from Archive (Next-Flip#510)
- Apps: Add ISO 15693-3 NFC Writer (by ch4istO)
- SubGHz: Major protocol updates including:
  * Added AES common module for encryption
  * Added Beninca ARC protocol
  * Added Treadmill37 protocol
  * Removed Kia, Scher Khan, and Star Line protocols
  * Updated many existing protocols with AES support
- Unit test resource updates and improvements
- Documentation updates for SubGHz settings and supported systems

This brings kiisu-mntm up to date with dev (c176524) while preserving all kiisu-mntm-specific changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

NFC emulate ISO15693-3 Flipper crash and reboot

2 participants