NFC: Enable writing button for ULC and NTAG I2C#504
Closed
Conversation
|
Compiled f7 firmware for commit
|
Member
Author
|
closing as this is not sufficient to make writing work and i currently dont intend to implement writing for ULC or NTAG I2C |
aaronjamt
reviewed
Jan 23, 2026
Comment on lines
217
to
219
| } | ||
|
|
||
| if(is_locked) { |
Member
There was a problem hiding this comment.
These 3 lines could also be removed.
Member
|
At least for ULC, I see the following log output spammed indefinitely: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Enables writing for MIFARE Ultralight C and NTAG I2C cards. Currently not tested whether writing to them works, just the button is now visible and clickable.
For the reviewer