test: QA-103 manually set game location to manage a game#23697
Open
RedRanger14 wants to merge 3 commits into
Open
test: QA-103 manually set game location to manage a game#23697RedRanger14 wants to merge 3 commits into
RedRanger14 wants to merge 3 commits into
Conversation
Covers Games [#8.8]: unmanaged game listed, 'Game not discovered' dialog shown, manual folder selection accepted, game becomes active and listed as Managed, and a mod installs for it. Extracts the showOpenDialog stub into helpers/dialogs and adds Managed/Unmanaged section and dialog locators to the GamesPage POM. Store selection is skipped by the app itself under VORTEX_E2E, and no UAC prompt occurs for user-writable fake game dirs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A failed probe build exited 0, so nx cached the empty result as
success and the app shipped without dotnetprobe - the renderer then
crashes at runtime ('Target crashed' in random e2e tests, seen on the
Linux runner). The build cache key also lacked the platform, letting
one OS's cached binary satisfy the other on shared caches.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The test steps run with continue-on-error, so a hard failure before Playwright starts (e.g. the app build aborting) was only visible as the encrypt step tripping over a missing test-results directory. Add an explicit check that fails with a pointer to the real log, and skip the encrypt/upload steps when there is nothing to archive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers Games [#8.8]: unmanaged game listed, 'Game not discovered' dialog shown, manual folder selection accepted, game becomes active and listed as Managed, and a mod installs for it. Extracts the showOpenDialog stub into helpers/dialogs and adds Managed/Unmanaged section and dialog locators to the GamesPage POM. https://linear.app/nexus-mods/issue/QA-103/games-88-manually-set-a-games-location-to-successfully-manage-it
Store selection is skipped by the app itself under VORTEX_E2E, and no UAC prompt occurs for user-writable fake game dirs.