fix(deps): Apply the required CometBFT security fix (CSA-2026-001) by upgrading CometBFT to the patched v0.37.18 across the root module and internal test modules#2512
Conversation
… upgrading CometBFT to the patched v0.37.18 across the root module and internal test modules
There was a problem hiding this comment.
Code Review
This pull request applies a critical security fix for CometBFT by upgrading it to v0.37.18. It also includes a wide range of other dependency updates to ensure compatibility and modernize the toolchain, including an upgrade to Go 1.22.
My review focuses on the consistency of these dependency updates. I've found several instances where dependencies in the vendored internal/cosmos-sdk module and its test modules are out of sync with the versions specified in the root go.mod. While the build might succeed by picking the highest version, this can lead to subtle compatibility issues. I've left detailed comments with suggestions to align these versions for better stability and maintainability.
| cosmossdk.io/math v1.4.0 | ||
| github.com/cometbft/cometbft v0.37.2 | ||
| github.com/cometbft/cometbft v0.37.18 | ||
| github.com/tidwall/gjson v1.14.2 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Primary Purpose
Applies required CometBFT security fix (CSA-2026-001) by upgrading CometBFT to the patched
v0.37.18across the root module and internal test modules, addressing a critical issueOther Changes
1.22.7(withtoolchain go1.22.12) to standardize builds on a modern Go version and better match the upgraded dependency set.Note
Medium Risk
Although mostly dependency updates, this touches consensus-engine and networking/telemetry stacks (CometBFT, gRPC, OpenTelemetry), which can cause subtle runtime or compatibility issues and should be validated via integration/regression testing.
Overview
Applies the CometBFT security patch by upgrading
github.com/cometbft/cometbfttov0.37.18in the rootgo.modand the internal Cosmos SDK/test modules.Also refreshes a large set of related dependencies (notably gRPC/protobuf, OpenTelemetry, Prometheus, Viper/Cobra, websocket/CORS, and various transitive libs) and updates the vendored Cosmos SDK module to Go
1.22.7withtoolchain go1.22.12, with correspondinggo.sumchurn.Written by Cursor Bugbot for commit ffca07d. Configure here.