Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the existing oil.svg icon with a new version. A review comment suggests renaming the auto-generated SVG IDs to include a unique prefix, preventing potential ID collisions when the icon is inlined in a web environment.
Comment on lines
+1
to
+23
| <svg width="600" height="600" viewBox="0 0 600 600" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <g clip-path="url(#clip0_5991_550)"> | ||
| <path d="M0 0H600V600H0V0Z" fill="url(#paint0_linear_5991_550)"/> | ||
| <g clip-path="url(#clip1_5991_550)"> | ||
| <path d="M301.575 229.135C365.795 229.135 430.801 212.491 430.801 180.674C430.801 148.857 365.795 132.214 301.575 132.214C237.356 132.214 172.347 148.857 172.347 180.674C172.347 212.491 237.356 229.135 301.575 229.135ZM358.11 180.674H374.266C378.726 180.674 382.341 176.214 382.341 180.674C382.341 185.135 378.726 188.752 374.266 188.752H358.11C353.65 188.752 350.036 185.135 350.036 180.674C350.036 176.214 353.65 180.674 358.11 180.674Z" fill="white"/> | ||
| <path d="M422.726 219.413C394.343 237.917 345.605 245.288 301.575 245.288C257.546 245.288 208.807 237.917 180.424 219.413V283.952C175.458 288.599 172.551 295.032 172.347 301.826C172.347 333.643 237.356 350.286 301.575 350.286C365.795 350.286 430.801 333.643 430.801 301.826C430.597 295.032 427.689 288.599 422.726 283.952V219.413Z" fill="white"/> | ||
| <path d="M327.046 306.052C327.046 320.704 315.179 332.571 300.527 332.571C285.875 332.571 274.008 320.704 274.008 306.052C274.008 291.4 300.527 260.803 300.527 260.803C300.527 260.803 327.046 291.4 327.046 306.052Z" fill="#111317"/> | ||
| <path d="M422.726 340.562C394.343 359.066 345.605 366.437 301.575 366.437C257.546 366.437 208.807 359.066 180.424 340.562V405.101C175.458 409.748 172.551 416.181 172.347 422.975C172.347 454.792 237.356 471.435 301.575 471.435C365.795 471.435 430.801 454.792 430.801 422.975C430.597 416.181 427.689 409.748 422.726 405.101V340.562Z" fill="white"/> | ||
| </g> | ||
| </g> | ||
| <defs> | ||
| <linearGradient id="paint0_linear_5991_550" x1="111.621" y1="104.057" x2="730.146" y2="814.468" gradientUnits="userSpaceOnUse"> | ||
| <stop stop-color="#1A1E21"/> | ||
| <stop offset="1" stop-color="#06060A"/> | ||
| </linearGradient> | ||
| <clipPath id="clip0_5991_550"> | ||
| <rect width="600" height="600" rx="300" fill="white"/> | ||
| </clipPath> | ||
| <clipPath id="clip1_5991_550"> | ||
| <rect width="339.223" height="339.223" fill="white" transform="translate(132.215 132.214)"/> | ||
| </clipPath> | ||
| </defs> | ||
| </svg> |
Contributor
There was a problem hiding this comment.
The SVG uses auto-generated IDs (e.g., clip0_5991_550, paint0_linear_5991_550) which can cause collisions if multiple icons are inlined on the same page. This leads to rendering issues where one icon's properties (like gradients or clip paths) are incorrectly applied to another. It is recommended to use unique, descriptive prefixes for IDs. I have provided a suggestion with an oil_ prefix.
<svg width="600" height="600" viewBox="0 0 600 600" fill="none" xmlns="http://www.w3.org/2000/svg">
<g clip-path="url(#oil_clip0)">
<path d="M0 0H600V600H0V0Z" fill="url(#oil_paint0_linear)"/>
<g clip-path="url(#oil_clip1)">
<path d="M301.575 229.135C365.795 229.135 430.801 212.491 430.801 180.674C430.801 148.857 365.795 132.214 301.575 132.214C237.356 132.214 172.347 148.857 172.347 180.674C172.347 212.491 237.356 229.135 301.575 229.135ZM358.11 180.674H374.266C378.726 180.674 382.341 176.214 382.341 180.674C382.341 185.135 378.726 188.752 374.266 188.752H358.11C353.65 188.752 350.036 185.135 350.036 180.674C350.036 176.214 353.65 180.674 358.11 180.674Z" fill="white"/>
<path d="M422.726 219.413C394.343 237.917 345.605 245.288 301.575 245.288C257.546 245.288 208.807 237.917 180.424 219.413V283.952C175.458 288.599 172.551 295.032 172.347 301.826C172.347 333.643 237.356 350.286 301.575 350.286C365.795 350.286 430.801 333.643 430.801 301.826C430.597 295.032 427.689 288.599 422.726 283.952V219.413Z" fill="white"/>
<path d="M327.046 306.052C327.046 320.704 315.179 332.571 300.527 332.571C285.875 332.571 274.008 320.704 274.008 306.052C274.008 291.4 300.527 260.803 300.527 260.803C300.527 260.803 327.046 291.4 327.046 306.052Z" fill="#111317"/>
<path d="M422.726 340.562C394.343 359.066 345.605 366.437 301.575 366.437C257.546 366.437 208.807 359.066 180.424 340.562V405.101C175.458 409.748 172.551 416.181 172.347 422.975C172.347 454.792 237.356 471.435 301.575 471.435C365.795 471.435 430.801 454.792 430.801 422.975C430.597 416.181 427.689 409.748 422.726 405.101V340.562Z" fill="white"/>
</g>
</g>
<defs>
<linearGradient id="oil_paint0_linear" x1="111.621" y1="104.057" x2="730.146" y2="814.468" gradientUnits="userSpaceOnUse">
<stop stop-color="#1A1E21"/>
<stop offset="1" stop-color="#06060A"/>
</linearGradient>
<clipPath id="oil_clip0">
<rect width="600" height="600" rx="300" fill="white"/>
</clipPath>
<clipPath id="oil_clip1">
<rect width="339.223" height="339.223" fill="white" transform="translate(132.215 132.214)"/>
</clipPath>
</defs>
</svg>
AlexSmelov
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.