Execute the Provider ABI reference fixture - #1554
Conversation
|
Independent review handoff: please review exact head |
|
@athena-omt PR #1554 is green on exact head |
|
@athena-omt Please independently review PR #1554 at exact head |
Run a compiled C probe through descriptor negotiation, owned-buffer release, and invalid-handle rejection so the Provider ABI v1 gate verifies behavior as well as symbols. Refs #1453
77dd98a to
2c48011
Compare
athena-omt
left a comment
There was a problem hiding this comment.
Reviewed exact head 2c48011 on Athena. The runtime probe, checker negative suite (29 cases), workflow contract test, and diff check pass locally. I cannot approve while CI Gate and Fast Checks are failing on this same head. PR author: diagnose and repair or rerun Fast Checks, then request re-review against the resulting green exact head.
athena-omt
left a comment
There was a problem hiding this comment.
Reviewed exact head d67dfae2b408ce01e85669e02d87b25f8f782e62 on Athena. The Provider ABI runtime probe is sound; the checker, its 29 negative cases, and the PR Fast CI workflow contract test pass locally. I cannot approve this head: it is behind current main (11d89e881e4f31ce8fce02caff5ae5693552ef03) and its exact-head checks fail (Fast Checks, Lockfile Integrity, Vetting, and SBOM, and the dependent CI Gate). Fast Checks failed with runner storage exhaustion (No space left on device); the Provider ABI fixture itself passed. PR author: update the branch with current main and obtain green exact-head checks, then request re-review. Infrastructure owner: remediate runner capacity if the failure recurs.
athena-omt
left a comment
There was a problem hiding this comment.
Reviewed exact head 03e0ad1706dea11f803c7a2f8b2af7dea8a4c0a1 on Athena. The new probe compiles and runs the C fixture, and targeted checker, 29-case negative suite, workflow contract test, and git diff --check pass locally.
Request changes: the probe claims invalid-handle rejection but only exercises axiom_provider_close_handle(0). It never calls axiom_provider_call with an invalid handle, so the fixture's operation-dispatch rejection path (if (!h || !out) return -1) can regress without this new runtime probe catching it. Add an assertion that axiom_provider_call(0, input, &output) fails, then rerun the targeted checks.
The branch is current with main, but its exact-head checks remain queued (Detect Relevant Changes, Validate Secrets, Lockfile Integrity, Vetting, and SBOM, and Validate PR Description); obtain completed green required checks after the repair before re-review.
Summary
Governing Issue
Refs #1453
Validation
CI GateLocal checks:
git diff --checkpython3 scripts/ci/check-provider-abi-v1.py --target test-targetpython3 scripts/ci/test-check-provider-abi-v1.py(29 negative cases)The structured autoreview helper was attempted but its model/MCP transport disconnected before producing a review result.
Bootstrap Governance
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md, anddocs/bootstrap/onboarding.mdwhen applicableFlow Contract
Flow Merge Readiness
Merge Automation
gh pr merge --auto --squash, or the reason it is unavailable/unsafe is noted belowAuto-merge is not enabled: the required independent Athena review must approve the exact head before merge.
Notes
athena-omtis required before merge.