Skip to content

fix: prevent PDF generation crash on non-latin-1 characters in AI output #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
advaitpatel merged 1 commit into from
Jun 24, 2026
Merged

fix: prevent PDF generation crash on non-latin-1 characters in AI output #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions docksec/report_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,21 @@ def __init__(self):
super().__init__()
self.set_auto_page_break(True, margin=15)

@staticmethod
def _safe(text: str) -> str:
return (
text
.replace("—", "--")
.replace("–", "-")
.replace("‘", "'")
.replace("’", "'")
.replace("“", '"')
.replace("”", '"')
.replace("…", "...")
.encode("latin-1", errors="replace")
.decode("latin-1")
)

def multi_cell_with_title(self, title, content, title_w=40):
"""Create title-content pair with multi-line support"""
self.set_font("helvetica", "B", 10)
Expand All @@ -210,7 +225,7 @@ def multi_cell_with_title(self, title, content, title_w=40):
self.cell(title_w, 7, title)
self.set_font("helvetica", "", 10)
self.set_xy(x_start + title_w, y_start)
self.multi_cell(0, 7, content, new_x=XPos.LMARGIN, new_y=YPos.NEXT)
self.multi_cell(0, 7, self._safe(content), new_x=XPos.LMARGIN, new_y=YPos.NEXT)
self.ln(2)

def add_section_header(self, title):
Expand Down Expand Up @@ -251,7 +266,7 @@ def add_section_header(self, title):
pdf.cell(0, 7, "Vulnerabilities:", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.set_font("helvetica", "", 9)
for i, vuln in enumerate(ai_findings["vulnerabilities"], 1):
pdf.multi_cell(0, 5, f"{i}. {vuln}", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.multi_cell(0, 5, pdf._safe(f"{i}. {vuln}"), new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.ln(2)

# Best Practices
Expand All @@ -260,7 +275,7 @@ def add_section_header(self, title):
pdf.cell(0, 7, "Best Practices:", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.set_font("helvetica", "", 9)
for i, practice in enumerate(ai_findings["best_practices"], 1):
pdf.multi_cell(0, 5, f"{i}. {practice}", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.multi_cell(0, 5, pdf._safe(f"{i}. {practice}"), new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.ln(2)

# Security Risks
Expand All @@ -269,7 +284,7 @@ def add_section_header(self, title):
pdf.cell(0, 7, "Security Risks:", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.set_font("helvetica", "", 9)
for i, risk in enumerate(ai_findings["security_risks"], 1):
pdf.multi_cell(0, 5, f"{i}. {risk}", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.multi_cell(0, 5, pdf._safe(f"{i}. {risk}"), new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.ln(2)

# Exposed Credentials
Expand All @@ -278,7 +293,7 @@ def add_section_header(self, title):
pdf.cell(0, 7, "Exposed Credentials:", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.set_font("helvetica", "", 9)
for i, cred in enumerate(ai_findings["exposed_credentials"], 1):
pdf.multi_cell(0, 5, f"{i}. {cred}", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.multi_cell(0, 5, pdf._safe(f"{i}. {cred}"), new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.ln(2)

# Remediation Steps
Expand All @@ -287,7 +302,7 @@ def add_section_header(self, title):
pdf.cell(0, 7, "Remediation Steps:", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.set_font("helvetica", "", 9)
for i, step in enumerate(ai_findings["remediation"], 1):
pdf.multi_cell(0, 5, f"{i}. {step}", new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.multi_cell(0, 5, pdf._safe(f"{i}. {step}"), new_x=XPos.LMARGIN, new_y=YPos.NEXT)
pdf.ln(5)

# Image Information (if available)
Expand Down
Loading