Skip to content

Enhance vectorizer config handling in project.py #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaedeser wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enhance vectorizer config handling in project.py #735

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e03061c
Enhance vectorizer config handling in project.py
Kaedeser Jan 9, 2026
6967b94
Fix according to the suggestions and resubmit.
Kaedeser Jan 29, 2026
771b4ce
repair
Kaedeser Jan 29, 2026
9716213
fix completed
Kaedeser Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions knext/command/sub_command/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,18 @@ def create_project(
llm_config_checker = LLMConfigChecker()
vectorize_model_config_checker = VectorizeModelConfigChecker()
llm_config = config.get("chat_llm", {})
vectorize_model_config = config.get("vectorizer", {})
vectorize_model_config = config.get("vectorizer", {}) or config.get(
Copy link
Copy Markdown
Collaborator

@whfcarter whfcarter Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty dict triggers the second part of 'or'

"vectorize_model", {}
)
if "vectorizer" not in config and "vectorize_model" in config:
Comment thread
Kaedeser marked this conversation as resolved.
Outdated
config["vectorizer"] = config.get("vectorize_model", {})
Copy link
Copy Markdown
Collaborator

@whfcarter whfcarter Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is unnecessary since the key existence was already checked.

Suggest changing to

config["vectorizer"] = config["vectorize_model"]

try:
llm_config_checker.check(json.dumps(llm_config))
dim = vectorize_model_config_checker.check(json.dumps(vectorize_model_config))
config["vectorizer"]["vector_dimensions"] = dim
if "vectorizer" in config and isinstance(config["vectorizer"], dict):
config["vectorizer"]["vector_dimensions"] = dim
if "vectorize_model" in config and isinstance(config["vectorize_model"], dict):
config["vectorize_model"]["vector_dimensions"] = dim
except Exception as e:
click.secho(f"Error: {e}", fg="bright_red")
sys.exit()
Expand Down
Loading