Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just leaving this here in case you find it useful.
Yesterday, Maxim, Rachel and I realised that the current documentation & setup & nextflow pipeline was leaving us with
_entry.idthat includes-model-${params.version}e.g.-model-v1for my ATBC data. However, it is desired that the_entry.iddoes not include this.After some digging, we realised that
_entry.idis created based on the input.pdbfilename - so our options were:.pdbfile to${entry}.pdbomitting-model-${params.version}; or.ciffile afterwards with some kind of custom script.This nextflow script is updated to implement option 1.
I also note here that you also need to make sure the first
.cifmade byrunModelCifGeneratordoes not include-model-${params.version}, or else DSSP will not add the right tag either and the resulting mmcif fails gemmi validation.So the input to DSSP needs to also be
${entry}.cif. Only after DSSP is run can the output include-model-${params.version}. This is implemented in this PR.I note that this code works, but it includes in its output the intermediate
${entry}.cif(which does not include the DSSP information). I am a nextflow rookie and don't have time to spare, so I am not going to invest time into figuring out how to delete these intermediate mmcifs in the pipeline (I am just doing it manually after the pipeline is run at this point), but I am sure you can figure it out.George