Improve RTL support by using CSS Logical Properties - #1192
Open
babakfp wants to merge 9 commits into
Open
Conversation
`transform-origin: top left` must be `top right` in RTL.
bglw
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1191
only the files in
pagefind_uifolder are edited.not sure about
pagefind_ui/default/_dev_files/water.cssnot sure about logical properties with things like
env(safe-area-inset-left):not sure what is
:is(*, #\#), but based on the merged changes in https://github.com/Pagefind/pagefind/pull/1086/changes#diff-46dab2ee5ab4f506b722261382bdc989883b68f44f5930b7890bc052adc8aa7bL719, changes to:is(*, #\#)should be finei couldn't run the project and test the changes!
after a whole bunch of fighting with wsl, docker and whatever, i reached this point and, honestly, this shit sucks... why does even a search util needs rust and docker?! :|