Skip to content

Improve RTL support by using CSS Logical Properties - #1192

Open
babakfp wants to merge 9 commits into
Pagefind:mainfrom
babakfp:css_logical_fix
Open

Improve RTL support by using CSS Logical Properties#1192
babakfp wants to merge 9 commits into
Pagefind:mainfrom
babakfp:css_logical_fix

Conversation

@babakfp

@babakfp babakfp commented Jun 9, 2026

Copy link
Copy Markdown

fixes: #1191

only the files in pagefind_ui folder are edited.

not sure about pagefind_ui/default/_dev_files/water.css

not sure about logical properties with things like env(safe-area-inset-left):

padding-inline-start: max(16px, env(safe-area-inset-left));

not sure what is :is(*, #\#), but based on the merged changes in https://github.com/Pagefind/pagefind/pull/1086/changes#diff-46dab2ee5ab4f506b722261382bdc989883b68f44f5930b7890bc052adc8aa7bL719, changes to :is(*, #\#) should be fine


i couldn't run the project and test the changes!

after a whole bunch of fighting with wsl, docker and whatever, i reached this point and, honestly, this shit sucks... why does even a search util needs rust and docker?! :|

|> just install                                                                                                                                                            
Error: Node.js is required but not installed. Please install Node.js first.                                                                                                
error: recipe `install-npm` failed on line 17 with exit code 1

@babakfp
babakfp requested a review from bglw as a code owner June 9, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pagefind is not using css logical properties and getting rtl issues as a result

2 participants