Add mypermissions endpoint#5538
Open
WilliamBZA wants to merge 5 commits into
Open
Conversation
… to readonly fields for improved clarity and consistency within the method.
ramonsmits
reviewed
Jun 17, 2026
|
|
||
| [ApiController] | ||
| [Route("api")] | ||
| [Authorize] |
Member
There was a problem hiding this comment.
Will this work when auth is disabled? Will we assume that SP will not invoke this API when auth is disabled?
Instead we would use AllowAnonymous and have fallback logic.
| { | ||
| [HttpGet] | ||
| [Route("my/permissions/all")] | ||
| public ActionResult<PermissionsDescriptor> GetMyPermissions() |
Member
There was a problem hiding this comment.
Maybe use all as that is part of the route?
Suggested change
| public ActionResult<PermissionsDescriptor> GetMyPermissions() | |
| public ActionResult<PermissionsDescriptor> GetAllPermissions() |
| public ActionResult<PermissionsDescriptor> GetMyPermissions() | ||
| { | ||
| var descriptor = new PermissionsDescriptor( | ||
| User.FindFirst("sub")?.Value ?? User.Identity?.Name ?? "unknown", |
Member
There was a problem hiding this comment.
What are we returning here? a user Id or display name? Can't we assume sub to always exist and not be null when a user is authenticated?
Suggested change
| User.FindFirst("sub")?.Value ?? User.Identity?.Name ?? "unknown", | |
| User.FindFirst("sub"), |
Member
There was a problem hiding this comment.
@WilliamBZA in:
I added configurable settings for these keys
| { | ||
| var descriptor = new PermissionsDescriptor( | ||
| User.FindFirst("sub")?.Value ?? User.Identity?.Name ?? "unknown", | ||
| GrantedPermissions().OrderBy(p => p, StringComparer.Ordinal).ToList()); |
Member
There was a problem hiding this comment.
Do we really need to order server side? Should we always order client side anyway?
Suggested change
| GrantedPermissions().OrderBy(p => p, StringComparer.Ordinal).ToList()); | |
| GrantedPermissions() | |
| ).ToList()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 2 HTTP endpoints: