Attempt to fix issues with BuildLimitGroup#2285
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
so far no issue has occured in testing, but I'm not sure whether they're all resolved. Would require some more test and review |
|
It would be best to provide an analysis of the errors in the previous implementation and their resulting consequences. Simply put, it should cover "how things were done before", "why the previous approach was wrong", and "how things are done now". |
|
tbh I don't quite understand the idea of original author either, so it's just about fixing these 2 flaws:
So what I'm doing here is basically merging all EAX calculation into one function, and make it only affect Upgrade Anyway, testing suggested that it can fix the issue of production being interrupted when the factories got changed (e.g. building a new one, EMP a current one etc). However, the 50% production stuck issue still happens sometime. Not sure if I have a way to fix it for now |
Previously BuildLimitGroup has several issues. E.g. Techno is still buildable when it's reaching the limit but stuck at 50% building progress under certain conditions. This is an attempt to fix some of the issues, which refractor the code of BuildLimitGroup on upgrade to make it work independently from other techno