Implement country-defined crew#2301
Open
Sovietianqi wants to merge 3 commits into
Open
Conversation
|
To Chinese users:
|
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
TaranDahl
requested changes
Jul 21, 2026
TaranDahl
left a comment
TaranDahl
left a comment
Contributor
There was a problem hiding this comment.
Docs needed. You can ask your agent to generate it.
| if (!pHouse) | ||
| return 0; | ||
|
|
||
| auto pHouseTypeExt = HouseTypeExt::ExtMap.Find(pHouse->Type); |
Contributor
There was a problem hiding this comment.
Find func is now deprecated.
| if (pHouseTypeExt && pHouseTypeExt->Crew.isset()) | ||
| { | ||
| R->EAX(pHouseTypeExt->Crew.Get()); | ||
| } |
Contributor
There was a problem hiding this comment.
Incorrect Nullable template usage.
Comment on lines
+41
to
+48
| GET(TechnoClass*, pThis, ECX); | ||
|
|
||
| if (!pThis) | ||
| return 0; | ||
|
|
||
| HouseClass* pHouse = pThis->Owner; | ||
| if (!pHouse) | ||
| return 0; |
|
To Chinese users:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can specify the crew for each country by adding Crew=infantry type under the corresponding [country] section.
For example:
This allows you to define which infantry type serves as the crew for that country.