Skip to content

1675 read cosserat mesh - #1743

Merged
Rohit-Kakodkar merged 6 commits into
PrincetonUniversity:1675-cosserat-meshfrom
maxlchien:1675-read-cosserat-mesh
Mar 25, 2026
Merged

1675 read cosserat mesh#1743
Rohit-Kakodkar merged 6 commits into
PrincetonUniversity:1675-cosserat-meshfrom
maxlchien:1675-read-cosserat-mesh

Conversation

@maxlchien

@maxlchien maxlchien commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds a branch to read in elastic cosserat materials from the mesh file.
They are specified with material_id=4. For instance, the following line in a Mesh_Par_file:
1 2300.0 1500.0 2800.0 1e6 1e4 300.0 25.0 500.0 4
produces a material with
$\rho=2300,\kappa=1500,\mu=2800,\nu=1e6,j=1e4,\lambda_c=300,$ (4 specifies cosserat materials), $\mu_c=25,\nu_c=500$

An additional test case for mesh reading for Cosserat materials is added under tests/unit-tests/data/dim3/EightNodeElasticCosserat/.

Issue Number

#1675

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@buildbot-princeton

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

2 similar comments
@buildbot-princeton

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@buildbot-princeton

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@maxlchien maxlchien added the enhancement New feature or request label Mar 19, 2026
@maxlchien maxlchien added this to the 3D Cosserat Media milestone Mar 19, 2026
@lsawade

lsawade commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

test this please

@lsawade

lsawade commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

please merge devel, it should fix failing!

@Rohit-Kakodkar Rohit-Kakodkar added enhancement New feature or request and removed enhancement New feature or request labels Mar 24, 2026
@maxlchien

maxlchien commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator Author

please merge devel, it should fix failing!

devel has now been merged, fixing the previously failing tests. There will still be failing tests for the new EightNodeElasticCosserat case until #1739 is merged.

@Rohit-Kakodkar
Rohit-Kakodkar changed the base branch from devel to 1675-cosserat-mesh March 25, 2026 12:28
@Rohit-Kakodkar

Copy link
Copy Markdown
Collaborator

devel has now been merged, fixing the previously failing tests. There will still be failing tests for the new EightNodeElasticCosserat case until #1739 is merged.

Hi @maxlchien, I created a temporary branch so that the tests can also be updated before we merge into devel. Can you change the base for #1739 to 1675-cosserat-mesh

@Rohit-Kakodkar
Rohit-Kakodkar merged commit 47b29ad into PrincetonUniversity:1675-cosserat-mesh Mar 25, 2026
6 of 8 checks passed
@maxlchien

Copy link
Copy Markdown
Collaborator Author

devel has now been merged, fixing the previously failing tests. There will still be failing tests for the new EightNodeElasticCosserat case until #1739 is merged.

Hi @maxlchien, I created a temporary branch so that the tests can also be updated before we merge into devel. Can you change the base for #1739 to 1675-cosserat-mesh

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ignore-for-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants