Skip to content

Issue 1820 - Enforce free surface boundary - #2010

Open
icui wants to merge 8 commits into
develfrom
issue-1820-2
Open

Issue 1820 - Enforce free surface boundary #2010
icui wants to merge 8 commits into
develfrom
issue-1820-2

Conversation

@icui

@icui icui commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Description

(Opening a new PR because GitHub is not showing the correct diffs in the old one).
Applies free surface boundary condition after source interaction.

Issue Number

Closes #1820

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@icui
icui requested a review from Rohit-Kakodkar July 30, 2026 15:26

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retest this please

@Rohit-Kakodkar

Copy link
Copy Markdown
Collaborator

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants