Skip to content

fix(security): resolve DoS vulnerability and rate limit bypass in badge rate limiter (#3120) #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
desireddymohithreddy0925 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): resolve DoS vulnerability and rate limit bypass in badge rate limiter (#3120) #3142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/lib/badge-rate-limit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,12 @@ export type BadgeRateLimitResult = {
reset: number;
};

let lastPrune = Date.now();

function pruneStore(now: number): void {
if (store.size < 500) return;
if (now - lastPrune < 60000) return; // Only prune once per minute
lastPrune = now;
const cutoff = now - WINDOW_MS;
for (const [key, entry] of store) {
if (entry.windowStart < cutoff) store.delete(key);
Expand Down Expand Up @@ -61,10 +65,12 @@ export function checkBadgeRateLimit(ip: string): BadgeRateLimitResult {
}

export function getBadgeClientIp(req: NextRequest): string {
// Use Vercel's trusted IP header or fallback to connection IP
// Do NOT blindly trust x-forwarded-for as it can be easily spoofed
return (
req.headers.get("x-forwarded-for")?.split(",")[0]?.trim() ??
req.headers.get("x-real-ip") ??
(req as NextRequest & { ip?: string }).ip ??
req.headers.get("x-vercel-forwarded-for") ||
req.headers.get("x-real-ip") ||
(req as NextRequest & { ip?: string }).ip ||
"unknown"
);
}
Loading