perf(render): memoize PinnedRepos/TopRepos cards and fix stale closure in togglePin#3150
Open
surya0904shankar wants to merge 1 commit into
Open
Conversation
|
Thanks for your first PR on DevTrack! 🎉 A maintainer will review it within 48 hours. While you wait:
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors! |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
togglePininsidesrc/components/TopRepos.tsx— it previously readpinnedReposdirectly from its render closure and was recreated on every render, which could cause it to act on outdated pin data once cards stopped re-rendering unnecessarily (as a result ofReact.memo).togglePinas auseCallbackwith an empty dependency array, using the functionalsetPinnedRepos(prev => ...)update form so it always operates on the latest state.React.memo(with strict field-by-field comparators) onRepoCard(PinnedRepos.tsx) andRepoItem(TopRepos.tsx), anduseMemoon sorting/filtering logic (sortedPinnedRepos,filteredRepos/maxCommits) were already in place and working correctly as required by the issue.How to Test
Expected result: Pin/unpin behaves correctly under repeated toggles without acting on stale pin state, and repo cards no longer re-render wholesale on every data refresh.
Screenshots / Recordings
Not applicable — this is a performance/behavior fix with no visual UI changes.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locally (could not verify — ESLint ran out of memory on this machine when linting the fullsrcdirectory; unrelated to the changed files)npm run type-check) (not run locally — please confirm via CI)togglePinif requested)Accessibility (UI changes only)
Not applicable — no UI changes in this PR.
Additional Context
Closes #1458The memoization requirements from the issue (
React.memowith a strict comparator on cards,useMemofor sorting) were already implemented in bothPinnedRepos.tsxandTopRepos.tsxprior to this PR. While reviewing the memoization logic, I found thattogglePininTopRepos.tsxhad a stale-closure bug that the memoization exposed: since cards no longer always re-render, some could hold an outdatedtogglePinreference capturing stalepinnedReposstate, causing an incorrect pin-limit check or broken rollback on a failed request. This PR fixes that closure bug so the memoization work is fully correct and safe.