Skip to content

Remove calls to deprecated CRM_Utils_Array::value #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dontub merged 1 commit into from
Oct 27, 2025
Merged

Remove calls to deprecated CRM_Utils_Array::value #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v3/Bic.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
}

}
catch (Exception $e) {

Check failure on line 68 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

In function "civicrm_api3_bic_getfromiban", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 68 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-stable 

In function "civicrm_api3_bic_getfromiban", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 68 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

In function "civicrm_api3_bic_getfromiban", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.
// not found? no problem, just keep looking
}
}
Expand Down Expand Up @@ -118,7 +118,7 @@
$option_group = civicrm_api3('OptionGroup', 'getsingle', ['name' => 'bank_list']);
$query['option_group_id'] = $option_group['id'];
}
catch (Exception $e) {

Check failure on line 121 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

In function "civicrm_api3_bic_get", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 121 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-stable 

In function "civicrm_api3_bic_get", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 121 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

In function "civicrm_api3_bic_get", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.
return civicrm_api3_create_error('OptionGroup not found. Reinstall extension!');
}

Expand All @@ -130,12 +130,12 @@
'bic' => $value['name'],
'country' => substr($value['value'], 0, 2),
'nbid' => substr($value['value'], 2),
'description' => CRM_Utils_Array::value('description', $value),
'title' => CRM_Utils_Array::value('label', $value),
'description' => $value['description'] ?? NULL,
'title' => $value['label'] ?? NULL,
];
}
}
catch (Exception $e) {

Check failure on line 138 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

In function "civicrm_api3_bic_get", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 138 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-stable 

In function "civicrm_api3_bic_get", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 138 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

In function "civicrm_api3_bic_get", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.
return civicrm_api3_create_error('Entity does not exist.');
}

Expand Down Expand Up @@ -190,7 +190,7 @@
try {
$option_group = civicrm_api3('OptionGroup', 'getsingle', ['name' => 'bank_list']);
}
catch (Exception $e) {

Check failure on line 193 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

In function "civicrm_api3_bic_stats", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 193 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-stable 

In function "civicrm_api3_bic_stats", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 193 in api/v3/Bic.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

In function "civicrm_api3_bic_stats", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.
return civicrm_api3_create_error('OptionGroup not found. Reinstall extension!');
}

Expand Down
Loading