Families/ adding base version of exponential family#67
Open
domosedy wants to merge 10 commits intoPySATL:mainfrom
Open
Families/ adding base version of exponential family#67domosedy wants to merge 10 commits intoPySATL:mainfrom
domosedy wants to merge 10 commits intoPySATL:mainfrom
Conversation
LeonidElkin
reviewed
Feb 20, 2026
Desiment
requested changes
Feb 21, 2026
domosedy
force-pushed
the
exponential-family
branch
2 times, most recently
from
779438f to
12516ff
Compare
LeonidElkin
requested changes
May 1, 2026
Comment on lines
+244
to
+259
| @dataclass(frozen=True, slots=True) | ||
| class IntervalND: | ||
| intervals: list[Interval1D] | ||
|
|
||
| def contains(self, x: Number | NumericArray) -> bool | BoolArray: | ||
| if not hasattr(x, "__iter__"): | ||
| x = np.array([x]) | ||
|
|
||
| return all( | ||
| x_coordinate in interval | ||
| for interval, x_coordinate in zip(self.intervals, x, strict=True) | ||
| ) | ||
|
|
||
| def __contains__(self, x: object) -> bool: | ||
| """Check if a single point is in the interval.""" | ||
| return bool(self.contains(cast(Number, x))) |
Collaborator
There was a problem hiding this comment.
Strange implementation of the contains method. If we check whether a point is contained in an N-dimensional interval, then at least we must accept an array of N elements, if we want to check M Points at once, then we must accept an array of M x N. You definitely don't need to implement the magic method __contains__ here
Author
There was a problem hiding this comment.
I think the case when we check M points at once isn't really needed.
__contains__ method is mandatory for in operator
Comment on lines
+30
to
+32
| type ParametrizedFunction = Callable[[Parametrization, Any], Any] | ||
| type SupportArg = Callable[[Parametrization], Support | None] | None | ||
| type NumberParameter = Number | NumericArray |
Collaborator
There was a problem hiding this comment.
Move those types to types.py. SupportArg is already used in parametric_family.py so change there as well. NumberParameter is a bad naming, better smth like ArrayLikeNumeric or
Author
There was a problem hiding this comment.
This type is not ArrayLike it's one of Number or Array. So I really don't know how to name this type
added 9 commits
May 3, 2026 23:35
domosedy
force-pushed
the
exponential-family
branch
from
66f7d09 to
f67f3fd
Compare
domosedy
force-pushed
the
exponential-family
branch
from
f67f3fd to
2d470c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.