Skip to content

View for fixed parameters#86

Merged
LeonidElkin merged 2 commits intomainfrom
view-for-fixed-parameters
May 10, 2026
Merged

View for fixed parameters#86
LeonidElkin merged 2 commits intomainfrom
view-for-fixed-parameters

Conversation

@MyznikovFD
Copy link
Copy Markdown
Collaborator

No description provided.

@MyznikovFD MyznikovFD self-assigned this Apr 23, 2026
@MyznikovFD MyznikovFD added the Enhancement New feature or request label Apr 23, 2026
@MyznikovFD MyznikovFD force-pushed the view-for-fixed-parameters branch 6 times, most recently from 621aece to b044074 Compare April 30, 2026 19:20
Copy link
Copy Markdown
Collaborator

@LeonidElkin LeonidElkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an example of using this functionality to the overview after the edits.

Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py
@MyznikovFD MyznikovFD force-pushed the view-for-fixed-parameters branch 3 times, most recently from bfe1cbd to f666fa1 Compare May 4, 2026 16:47
Copy link
Copy Markdown
Collaborator

@LeonidElkin LeonidElkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected model for this feature:

  • After fixing one or more parameters, the result should be a real ParametricFamily subclass.
  • The resulting view should expose exactly one parametrization.
  • The parametrization used for fixing parameters becomes the view's local base parametrization.
  • The view may keep additional metadata about fixed parameters.
  • Analytical characteristics should remain available whenever they can be expressed through the
    view parametrization.

In other words, the partial family should behave like a normal one-parametrization
ParametricFamily, with fixed-parameter metadata layered on top.

Comment thread src/pysatl_core/families/parametric_family.py
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py
Comment thread tests/unit/families/test_partial_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py
@MyznikovFD MyznikovFD force-pushed the view-for-fixed-parameters branch 3 times, most recently from 3cb5eb1 to 4be0c95 Compare May 9, 2026 15:25
@MyznikovFD MyznikovFD requested a review from LeonidElkin May 9, 2026 17:44
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py
@MyznikovFD MyznikovFD force-pushed the view-for-fixed-parameters branch from 4be0c95 to fd732c9 Compare May 9, 2026 21:52
@MyznikovFD MyznikovFD force-pushed the view-for-fixed-parameters branch from fd732c9 to 137fea6 Compare May 9, 2026 21:55
@MyznikovFD MyznikovFD requested a review from LeonidElkin May 9, 2026 21:58
@LeonidElkin LeonidElkin merged commit 254360a into main May 10, 2026
20 checks passed
@LeonidElkin LeonidElkin deleted the view-for-fixed-parameters branch May 10, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core.families Enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants