KNITROAMPL: use \$KNITRODIR/knitroampl/knitroampl for executable#3979
Open
yemine0x01 wants to merge 2 commits into
Open
KNITROAMPL: use \$KNITRODIR/knitroampl/knitroampl for executable#3979yemine0x01 wants to merge 2 commits into
yemine0x01 wants to merge 2 commits into
Conversation
…ookup Add \$KNITRODIR/knitroampl/knitroampl as the first candidate in _default_executable(), before the knitro Python package path and the system PATH fallback. This allows users with a standalone Knitro installation (no Python package) to be picked up automatically via the KNITRODIR environment variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
NA
Summary/Motivation:
Some
KNITROusers install it as a standalone package (not via the Python knitro module) and rely on theKNITRODIRenvironment variable to locate their installation. Previously,_default_executable()only checked the knitro Python package path first, then fell back to a plain PATH search, meaning users with aKNITRODIR-based installation but no Python package would only succeed ifknitroamplhappened to be on their PATH.This PR adds an explicit lookup for
$KNITRODIR/knitroampl/knitroamplas the highest-priority candidate, reflecting the standard layout of a standalone KNITRO installation.Changes proposed in this PR:
AI-Use Disclosure
or
AI tools contributed to the development of this PR
Review process (select ONE):
Notes for reviewers (optional):
AI was used only for generating the commit message.
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: