feat(QOV-1794): Managed API token & AI Copilot role#2649
Open
killiancolla wants to merge 1 commit intonew-navigationfrom
Open
feat(QOV-1794): Managed API token & AI Copilot role#2649killiancolla wants to merge 1 commit intonew-navigationfrom
killiancolla wants to merge 1 commit intonew-navigationfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2649 +/- ##
==================================================
+ Coverage 44.92% 44.97% +0.05%
==================================================
Files 1135 787 -348
Lines 23773 19031 -4742
Branches 6898 5582 -1316
==================================================
- Hits 10679 8560 -2119
+ Misses 11221 8961 -2260
+ Partials 1873 1510 -363
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RemiBonnet
reviewed
May 4, 2026
Member
RemiBonnet
left a comment
RemiBonnet
left a comment
There was a problem hiding this comment.
Thanks @killiancolla and I added small comments!
| const errorBody = await response.json() | ||
| if (errorBody?.error) errorMessage = errorBody.error | ||
| // eslint-disable-next-line no-empty | ||
| } catch (_) {} |
Member
There was a problem hiding this comment.
Could you avoid adding linter disabling here?
| } catch (error) { | ||
| if (error && typeof error === 'object' && 'response' in error) { | ||
| const axiosError = error as { response?: { data?: { error?: string } } } | ||
| const backendMessage = axiosError.response?.data?.error |
Member
There was a problem hiding this comment.
I'm not sure to understand why do you need to add it ?
console.error('Error', error) should be enough no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: QOV-1794
Added a new way to authenticate with the copilot using a role-linked token.
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release