Skip to content

feat(QOV-1891): add cluster DNS provider settings.#2662

Draft
pggb25 wants to merge 2 commits intonew-navigationfrom
feat/dns-provider
Draft

feat(QOV-1891): add cluster DNS provider settings.#2662
pggb25 wants to merge 2 commits intonew-navigationfrom
feat/dns-provider

Conversation

@pggb25
Copy link
Copy Markdown
Collaborator

@pggb25 pggb25 commented May 6, 2026

Description:

Add DNS provider settings page in the new cluster navigation Support Qovery, Cloudflare, and Route53 configuration Gate editing behind Enterprise plan and keep non-Enterprise view read-only Use generated API client for DNS provider GET/PUT calls

Summary

Add DNS provider settings page in the new cluster navigation
Support Qovery, Cloudflare, and Route53 configuration
Gate editing behind Enterprise plan and keep non-Enterprise view read-only
Use generated API client for DNS provider GET/PUT calls

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@pggb25 pggb25 force-pushed the feat/dns-provider branch from a76a038 to b4429e7 Compare May 7, 2026 08:35
@pggb25 pggb25 changed the title feat(QOV-1891): add cluster DNS provider settings feat(QOV-1891): add cluster DNS provider settings. May 7, 2026
Description:

Add DNS provider settings page in the new cluster navigation
Support Qovery, Cloudflare, and Route53 configuration
Gate editing behind Enterprise plan and keep non-Enterprise view read-only
Use generated API client for DNS provider GET/PUT calls
@pggb25 pggb25 force-pushed the feat/dns-provider branch from b4429e7 to 4e4c8bc Compare May 7, 2026 08:46
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 53.33333% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.07%. Comparing base (36b5463) to head (c8fc236).
⚠️ Report is 4 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...rovider-settings/cluster-dns-provider-settings.tsx 60.37% 11 Missing and 10 partials ⚠️
...e-cluster-dns-provider/use-cluster-dns-provider.ts 0.00% 3 Missing ⚠️
...ster-dns-provider/use-edit-cluster-dns-provider.ts 0.00% 3 Missing ⚠️
...te-variable-modal/create-update-variable-modal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2662      +/-   ##
==================================================
+ Coverage           45.04%   45.07%   +0.02%     
==================================================
  Files                1148     1153       +5     
  Lines               24032    24089      +57     
  Branches             6984     7006      +22     
==================================================
+ Hits                10826    10858      +32     
- Misses              11313    11328      +15     
- Partials             1893     1903      +10     
Flag Coverage Δ
unittests 45.07% <53.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant