Skip to content

feat(devops-copilot): use tanstack router for internal links#2776

Open
killiancolla wants to merge 5 commits into
stagingfrom
fix/devops-copilot/internal-link
Open

feat(devops-copilot): use tanstack router for internal links#2776
killiancolla wants to merge 5 commits into
stagingfrom
fix/devops-copilot/internal-link

Conversation

@killiancolla

Copy link
Copy Markdown
Member

Summary

Use tanstack router for internal link to avoid reopen a new tab and to keep the chat open

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet

Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Take rest sometimes

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.50%. Comparing base (a3fc9cb) to head (4623c55).
⚠️ Report is 2 commits behind head on staging.

Files with missing lines Patch % Lines
.../devops-render-markdown/devops-render-markdown.tsx 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2776      +/-   ##
===========================================
- Coverage    46.64%   43.50%   -3.14%     
===========================================
  Files         1148      496     -652     
  Lines        24817    12869   -11948     
  Branches      7391     3949    -3442     
===========================================
- Hits         11575     5599    -5976     
+ Misses       11223     6302    -4921     
+ Partials      2019      968    -1051     
Flag Coverage Δ
unittests 43.50% <0.00%> (-3.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


if (internalPath) {
return (
<a

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use import { Link } from '@tanstack/react-router' instead of useNavigate ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment as discussed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants