feat(devops-copilot): use tanstack router for internal links#2776
feat(devops-copilot): use tanstack router for internal links#2776killiancolla wants to merge 5 commits into
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2776 +/- ##
===========================================
- Coverage 46.64% 43.50% -3.14%
===========================================
Files 1148 496 -652
Lines 24817 12869 -11948
Branches 7391 3949 -3442
===========================================
- Hits 11575 5599 -5976
+ Misses 11223 6302 -4921
+ Partials 2019 968 -1051
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| if (internalPath) { | ||
| return ( | ||
| <a |
There was a problem hiding this comment.
Could you use import { Link } from '@tanstack/react-router' instead of useNavigate ?
There was a problem hiding this comment.
I added a comment as discussed 🙏
Summary
Use tanstack router for internal link to avoid reopen a new tab and to keep the chat open
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release