Skip to content

[windows] Enable multi-arch packaging tests - #7630

Open
ScottTodd wants to merge 1 commit into
mainfrom
users/scotttodd/windows-test-packaging
Open

[windows] Enable multi-arch packaging tests#7630
ScottTodd wants to merge 1 commit into
mainfrom
users/scotttodd/windows-test-packaging

Conversation

@ScottTodd

@ScottTodd ScottTodd commented Aug 25, 2026

Copy link
Copy Markdown
Member

Motivation

These tests have not been running on Windows multi-arch CI, so we've been missing some early signal on whether CMake packages are working as expected.

Technical Details

The tests are already running on Linux:

- name: Test Packaging
run: |
ctest --test-dir ${BUILD_DIR} --output-on-failure

See also #7386, which handled hiptensor in these tests on Linux in a slightly different way:

  • # hipTensor is built conditionally to composable_kernel availability (CK is a hard
    # build dependency). _ck_enabled, set by math-libs/CMakeLists.txt, is OFF when
    # CK and hipTensor were filtered out for the selected gfx targets.
    # _hiptensor_available reflect the actual built status so the example does not
    # find_package() a missing hiptensor.
    set(_hiptensor_available OFF)
    if(_ck_enabled AND THEROCK_ENABLE_HIPTENSOR)
    set(_hiptensor_available ON)
    endif()
  • "-DTHEROCK_ENABLE_HIPTENSOR=${_hiptensor_available}"

Test Plan

Tests should pass for all build stages, regardless of which subprojects are enabled/disabled based on gfx target/family.

https://github.com/ROCm/TheRock/actions/runs/32867300087/job/97873081522?pr=7630
image

Submission Checklist

Skip hipSPARSELt package discovery on Windows, where the library is not built, while continuing to validate rocSPARSE and hipSPARSE. Enable ctest in Windows multi-arch artifact jobs.

Co-authored-by: OpenAI Codex <noreply@openai.com>
@therock-pr-bot

therock-pr-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@ScottTodd
ScottTodd marked this pull request as ready for review August 25, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant